← Back to issue list

Add unit and spread tests for the .NET (v2) plugin

View original Github issue

Metadata

Project
snapcraft
Number
#5534
Type
pull request
State
merged
Author
mateusrodrigues
Labels
Created
Updated
Closed

Current evaluation

Merged after rebase and test fixes. Updates .NET plugin tests by removing outdated spread tests, adding core24 cases to registered plugin tests, and introducing a dotnet-hello spread test. All CI checks passed with two approvals.

Suggested action:

No scores available.

Issue body

- [X] Have you followed the [guidelines for contributing](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [X] Have you successfully run `make lint`? - [X] Have you successfully run `make test`? --- - Removed the `dotnet-unregistered` spread test, which no longer applies now that there is a new .NET plugin registered for core24. - Removed the `test_application_dotnet_not_registered` test and added `core24` test cases to the `test_application_dotnet_registered` test, since the .NET plugin is now available on `core24` and later. - Added a `dotnet-hello` spread test that builds a simple Hello World .NET snap using the new .NET (v2) plugin to the already existing `build-and-run-hello` test suite.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged after rebase and test fixes. Updates .NET plugin tests by removing outdated spread tests, adding core24 cases to registered plugin tests, and introducing a dotnet-hello spread test. All CI checks passed with two approvals.
qwen3.6-35b-a3b-mtp-q6 Merged after the contributor rebased and fixed test failures to align with craft-parts 2.11.0. The update adds unit and spread tests for the .NET (v2) plugin, removes outdated registration tests, and introduces a dotnet-hello spread test for core24.
qwen3.6-35b-a3b-mtp-q6 Merged after rebasing and fixing test failures. Added unit and spread tests for the .NET v2 plugin, including core24 test cases and a new dotnet-hello spread test, while removing obsolete tests for the deprecated plugin registration.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#3020 spread tests: default base for local plugin tests snapcraft merged Merged updates to spread tests establishing a default base for local plugin tests. The change follows a prior commit pattern, adding two lines across two files. Approved by one reviewer and passed CI checks.
73%
#5976 test: add Ruby plugin spread tests snapcraft merged Merged after review and CI approval. Adds Ruby plugin spread tests to resolve #5966. Retargeted to the hotfix/8.14 branch to align with the plugin's introduction.
72%
#2212 tests: add spread suite for ruby plugin snapcraft merged Merged into master. Ruby plugin integration tests were consolidated into a new Spread suite, resolving LP: #1783840. The change modified 13 files, passed CI checks, and received reviewer approval.
72%
#2183 tests: add spread suite for cmake plugin snapcraft merged Merged into master, resolving LP #1783830 by migrating CMake plugin integration tests to a Spread suite. Approved, passed CI, and maintained 91.23% code coverage across 17 modified files.
71%
#4582 test: add core24 component spread tests snapcraft merged Merged after approval and passing CI. Adds core24 component spread tests by flattening and copying existing test files. Coverage increased slightly, and changes were landed on the feature/components branch.
71%
#2201 tests: add spread suite for nil plugin snapcraft merged Merged to add a Spread test suite for Nil plugin integration tests, resolving Launchpad bug #1783838. Approved by reviewers, passed CI, and updated 8 files.
71%
#2211 tests: add spread suite for ament plugin snapcraft merged Merged PR moves the Ament plugin snapd integration test to a Spread suite, resolving LP #1783827. Approved by one reviewer, passed CI, and updated 18 files with a minor coverage decrease.
70%
#3432 spread tests: remove legacy plugin tests snapcraft merged Merged removal of legacy plugin tests from the spread test suite. Deleted 665 lines across 29 files. Approved by reviewer, passed CI, and maintained coverage. Unrelated test failures were addressed in a separate PR.
70%
#6202 test(spread): create core26 spread test suite snapcraft merged Merged the core26 spread test suite, adding CI jobs and generalizing tests for core22, 24, and 26 across 419 files. Approved by two reviewers and passed most CI checks prior to integration.
70%