← Back to issue list

build providers: recreate instance if base changed

View original Github issue

Metadata

Project
snapcraft
Number
#2460
Type
pull request
State
merged
Author
cmatsuoka
Labels
—
Created
Updated
Closed

Current evaluation

Merged via commit 63d052f65: build providers now detect project base changes and recreate instances, resolving Launchpad bug #1794506.

Resolution: closed resolved

Reason: PR #2460 was merged with commit 63d052f65, adding base checks and instance recreation so provider contents remain consistent with the project base.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Once a build provider is provisioned, changes in project base are ignored and the existing VM is used for new builds. To ensure base and provider contents are consistent, we test base values at the start of each build and force instance recreation if base has changed. LP: #1794506 Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com> - [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [ ] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged via commit 63d052f65: build providers now detect project base changes and recreate instances, resolving Launchpad bug #1794506.
stealth/space-bunny-alpha — closed resolved Merged #2460 (63d052f65): build providers now detect project base changes and recreate the instance, fixing LP #1794506.
stealth/space-bunny-alpha — closed resolved Merged #2460 via commit 63d052f65: build providers now detect project-base changes and recreate the instance, fixing Launchpad #1794506.
qwen/qwen3.6-35b-a3b — — Merged fix ensuring build providers recreate instances when the project base changes. Previously, base updates were ignored after initial provisioning. This resolves Launchpad bug #1794506 and was approved and merged into master.
qwen3.6-35b-a3b-mtp-q6 — — Merged into master. Forces build provider instance recreation when the project base changes to maintain environment consistency. Resolves LP: #1794506.

Update history

No update history recorded yet.

Related work

  • Related To: launchpad#1794506 (confidence 100%)

    The PR explicitly identifies this Launchpad bug as the problem being fixed.

Related issues

Issue Project State Summary Similarity
#3202 build providers: fix base change warning message snapcraft merged Merged PR #3202 as commit c4e3c0ccb, correcting the misleading build-provider warning emitted when a base changes.
73%
#2267 build providers: refresh packages on bring up snapcraft merged Merged #2267 as commit 1df8068c0, moving package-repository refreshes into BaseProvider.start() and shared build-environment bring-up logic.
71%
#2374 build providers: destroy on create failures snapcraft merged Merged PR #2374 (commit ec0fbe2be, LP #1792242) adds cleanup so build providers are destroyed when creation/launch fails, preventing VMs from being left running.
70%