build providers: fix base change warning message
Metadata
Current evaluation
Merged PR #3202 as commit c4e3c0ccb, correcting the misleading build-provider warning emitted when a base changes.
Resolution: closed resolved
Reason: The approved change was merged in canonical/snapcraft#3202 at commit c4e3c0ccb.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Signed-off-by: Chris Patterson <chris.patterson@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #3202 as commit c4e3c0ccb, correcting the misleading build-provider warning emitted when a base changes. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in canonical/snapcraft#3202 as c4e3c0ccb, correcting the misleading build-provider warning emitted when a project's base changes. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in canonical/snapcraft#3202 as c4e3c0ccb, correcting the misleading build-provider warning emitted when a base changes. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged as snapcore/snapcraft#3202 (commit c4e3c0ccb), correcting the build-provider base-change warning message. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #3202 in commit c4e3c0ccb, correcting the warning message shown when a build provider's base changes. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged after approval and passing CI. The pull request fixes the base change warning message in build providers, updating one file with four additions and two deletions. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a fix correcting an inaccurate base change warning message in build providers. The maintainer-authored pull request was accepted and integrated without additional comments or revisions. |
Update history
No update history recorded yet.
Related work
-
Caused By:
canonical/snapcraft#3182
(confidence 75%)
The earlier warning improvement likely introduced the incorrect wording corrected by #3202.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3182 build providers: improve warning for unknown base | snapcraft | merged | Merged in #3182 via commit 7346d937f, improving build-provider warnings for unknown bases. | |
| #3180 build providers: nice message on bad base | snapcraft | merged | Merged in #3180 via commit 9e569f652, adding a dedicated exception and clearer handling for invalid bases in the LXD build provider. | |
| #2508 Build provider errors | snapcraft | merged | Merged PR #2508 in commit 8d8f411b3, enhancing build-provider error handling across two files (+353/-85 lines). | |
| #2460 build providers: recreate instance if base changed | snapcraft | merged | Merged via commit 63d052f65: build providers now detect project base changes and recreate instances, resolving Launchpad bug #1794506. | |
| #4505 chore: remove deprecated parameter `build-base` | snapcraft | merged | PR #4505 merged as 4aa5f63cb, dropping the deprecated build_base arg passed to craft-providers to silence its deprecation warning; the same cleanup had already landed on main via PR #4204 (d77b51466). | |
| #2474 build providers: remove dead code | snapcraft | merged | Merged PR #2474 as commit 4308dd8d3, removing obsolete build-provider methods left over from legacy cleanbuild support. | |
| #4204 providers: remove deprecated `build_base` parameter | snapcraft | merged | Merged PR #4204 via commit d77b51446, removing the deprecated build_base argument from craft-providers launched_environment() calls. |