← Back to issue list

cli: clean up snapcraft push output

View original Github issue

Metadata

Project
snapcraft
Number
#2469
Type
pull request
State
merged
Author
cmatsuoka
Labels
Created
Updated
Closed

Current evaluation

Merged cleanup of the snapcraft push CLI output. Verbose messages were moved to debug level, filename formatting was standardized, and log coloring was adjusted. Approved by one reviewer, passed CI, and integrated into the main branch.

Suggested action:

No scores available.

Issue body

The output of the 'snapcraft push' command shows too much information, often displayed in inconsistent format and with seemingly arbitrary colors (in fact, tied to the log level used for that line). This patch partially cleans up the output, moving unnecessary messages to debug level and making filename representation consistent across messages. The final success message remains colored green, as does a log message originary from the delta subsystem. We leave output colorization to be discussed later and resolved globally. LP: #1804439 Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com> - [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [ ] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged cleanup of the snapcraft push CLI output. Verbose messages were moved to debug level, filename formatting was standardized, and log coloring was adjusted. Approved by one reviewer, passed CI, and integrated into the main branch.
qwen3.6-35b-a3b-mtp-q6 Merged. Cleaned up snapcraft push CLI output by moving verbose messages to debug level, standardizing filename formatting with quotes, and refining prompts. Changes passed tests and review before integration.
qwen3.6-35b-a3b-mtp-q6 Merged. Cleans up snapcraft push CLI output by moving verbose messages to debug, standardizing filenames with single quotes, and removing redundant delta notifications. Success and release messages remain.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#283 Upload: Clean up output. snapcraft merged Merged improvements to snapcraft upload output, adding progress indicators and clarifying the OTP prompt to resolve Launchpad bug #1538692. Approved by reviewers. Test logger cleanup was deferred.
74%
#228 packages: run snap operations silently craft-parts merged Merged to fix #218 by running snap subprocesses silently, preventing stdout leakage that conflicts with craft-cli during lifecycle execution. Approved by one reviewer, passed CI, and modified two files (+32/-15 lines).
73%
#85 test: cleanup test now that we have a new enough snapcraft snapcraft-rocks merged Merged test cleanup after upgrading to a stable snapcraft version. Removes six lines of outdated test code. Approved by one reviewer, passed all CI checks, and successfully merged.
72%
#80 chore(core22-8): show snapcraft output snapcraft-rocks merged Merged into the core22-8 branch following two approvals and passing all CI checks. The commit enables snapcraft output visibility, modifying two files with a +13/-6 line change.
72%
#2646 cli: only say sorry for in-snapcraft issues snapcraft merged Merged into master after approval and passing CI. The change updates CLI error messaging to only apologize for in-snapcraft issues, removing leftover refactor code. The 3 additions and 2 deletions achieved 100% diff coverage.
71%
#2643 project, cli: clean up snap asset messages snapcraft merged Merged cleanup of snap asset messages. Mutes default and advanced search directories, corrects outlier paths, and updates project/CLI code. Approved by one reviewer, passed CI, and merged with 3 files changed (+65/-47).
71%
#1240 cli: improve push output. snapcraft merged Merged. Improves CLI push output by using file basenames for widget spacing, fixing duplicate messages, removing trailing spinners, and renaming upload to push. Approved by one reviewer with a +15/-12 diff across four files.
71%
#3917 commands: make help message consistent snapcraft merged Standardized inconsistent help message flags across snapcraft commands. The pull request was merged after approval and passing CI checks, applying a minimal four-line update to align CLI documentation.
70%
#1834319 Cleaning up output snapcraft (launchpad) closed Requesting cleanup of duplicate and verbose snapcraft output messages was closed without resolution. Zero comments indicate the suggestion was abandoned or superseded by later project refactors.
70%