cli: clean up snapcraft push output
Metadata
Current evaluation
Merged PR #2469 as commit 194589f0e, reducing snapcraft push noise, moving extra messages to debug level, and standardizing filename output.
Resolution: closed resolved
Reason: The approved PR was merged as commit 194589f0e, implementing the push-output cleanup tracked by LP #1804439. Global color handling was intentionally deferred.
Evaluated by: mr-cal-bot
No scores available.
Issue body
The output of the 'snapcraft push' command shows too much information,
often displayed in inconsistent format and with seemingly arbitrary
colors (in fact, tied to the log level used for that line). This patch
partially cleans up the output, moving unnecessary messages to debug
level and making filename representation consistent across messages.
The final success message remains colored green, as does a log message
originary from the delta subsystem. We leave output colorization to be
discussed later and resolved globally.
LP: #1804439
Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [ ] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #2469 as commit 194589f0e, reducing snapcraft push noise, moving extra messages to debug level, and standardizing filename output. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #2469 as commit 194589f0e, reducing push noise, demoting messages to debug, and standardizing quoted filenames; global color cleanup was deferred. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #2469 (commit 194589f0e) cleans up `snapcraft push` output: verbose messages dropped to debug level, single quotes around filenames, duplicate "Pushing" line removed. Fixes LP: #1804439; colorization left for later. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #2469 as commit 194589f0e, moving unnecessary push messages to debug level and standardizing quoted filenames; broader color changes were left for later. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged cleanup of the snapcraft push CLI output. Verbose messages were moved to debug level, filename formatting was standardized, and log coloring was adjusted. Approved by one reviewer, passed CI, and integrated into the main branch. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Cleaned up snapcraft push CLI output by moving verbose messages to debug level, standardizing filename formatting with quotes, and refining prompts. Changes passed tests and review before integration. |
Update history
No update history recorded yet.
Related work
-
Related To:
snapcraft (launchpad)#1804439
(confidence 100%)
Launchpad bug #1804439 tracked the inconsistent snapcraft push output.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1834319 Cleaning up output | snapcraft (launchpad) | closed | Noisy duplicate Snapcraft output was cleaned up by merged PR canonical/snapcraft#2643 (cd38acef9), with the fix released in Snapcraft 3.7.1. | |
| #1804439 Push output needs love | snapcraft (launchpad) | closed | Push output cleanup landed in snapcraft PR #2469 (commit 194589f0e): duplicate/full-path messages and the "cached source snap" line dropped to debug, filenames made consistent and shortened. | |
| #1609803 snapcraft cleanbuild --no-clean-up | snapcraft (launchpad) | closed | Cleanbuild debugging landed in snapcore/snapcraft PR #740 (commit a24083e75); follow-up PR #1404 made --debug enter a shell when builds fail. | |
| #648 Implemented `snapcraft release` | snapcraft | merged | Merged PR #648 implemented the snapcraft release command in commit 3567bd63f, adding 455 lines and removing 23 across 12 files. | |
| #5188 fix: improve error message from snapd pack | snapcraft | merged | Merged PR #5188 in commit a9fc44093, improving snapd pack failures by surfacing snapd's error output and fixing snapcraft#4499. | |
| #2922 cli: fix push on Windows | snapcraft | merged | Merged in canonical/snapcraft#2922 as commit fd1df2093, fixing Windows push by giving unsquashfs POSIX-formatted metadata paths instead of native Windows paths. | |
| #2062 packaging: simplify snapcraft.yaml | snapcraft | merged | Merged PR #2062 as commit 0ba7c13cc, simplifying snap/snapcraft.yaml (+86/-105, 4 files) to drop custom Python compilation and other components no longer needed for classic confinement after the 2.40 release. | |
| #873 Release changelog for 2.20 | snapcraft | merged | Snapcraft 2.20 release changelog merged via PR #873 in commit 5173514ed, adding 55 lines after two approvals. | |
| #2998 CODE_STYLE: update to reflect latest conventions | snapcraft | merged | PR #2998 updated Snapcraft's code-style configuration to the team's latest conventions and merged as commit 75342010e. | |
| #1538692 Clean up messages for uploads | snapcraft (launchpad) | closed | Upload output was cleaned up in canonical/snapcraft#283, merged as 0c37853c4 (implementation d18b3f8e3), hiding verbose messages and adding progress indicators. |