cli: fix push on Windows
Metadata
Current evaluation
Merged in canonical/snapcraft#2922 as commit fd1df2093, fixing Windows push by giving unsquashfs POSIX-formatted metadata paths instead of native Windows paths.
Resolution: closed resolved
Reason: PR #2922 was approved and merged. Commit fd1df2093 converts metadata paths to POSIX form for unsquashfs, resolving push failures on Windows.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh tests/unit`?
-----
Extracting the metadata didn't work on Windows, because it used os.path.join() and unsquashfs expected a Unix path rather than a Windows path
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged in canonical/snapcraft#2922 as commit fd1df2093, fixing Windows push by giving unsquashfs POSIX-formatted metadata paths instead of native Windows paths. | |
| stealth/space-bunny-alpha | — | closed resolved | PR #2922 by NickZ merged as commit fd1df2093 ("cli: fix push on Windows"), converting metadata paths passed to unsquashfs to POSIX form so metadata extraction works on Windows. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in #2922 (commit fd1df2093), fixing Windows push by passing unsquashfs POSIX-formatted metadata paths instead of native Windows paths. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #2922 (fd1df2093) fixed snapcraft push on Windows by passing unsquashfs POSIX-formatted paths instead of native Windows paths. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged a fix for the Windows push command failure caused by os.path.join generating incompatible paths for unsquashfs. The change updates path handling to use POSIX format, resolving the compatibility issue with 6 additions and 2 deletions. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged fix for Windows push failures caused by os.path.join() generating Windows-style paths for unsquashfs. Replaced with Unix-compatible path formatting to enable successful metadata extraction and push operations on Windows. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2949 cli: fix clean on Windows | snapcraft | merged | Merged PR #2949 fixed the clean command on Windows in commit 4e19c6174 by avoiding unavailable snapd and CPU-affinity calls. | |
| #2469 cli: clean up snapcraft push output | snapcraft | merged | Merged PR #2469 as commit 194589f0e, reducing snapcraft push noise, moving extra messages to debug level, and standardizing filename output. |