cli: Handle legitimate provider exec errors
Metadata
Current evaluation
Merged CLI update that handles legitimate provider execution errors without raising exceptions. Resolves SNAPCRAFT-FK, SNAPCRAFT-EF, and SNAPCRAFT-E5. Approved by reviewer and merged with 123 additions and 13 deletions across nine files.
Suggested action: —
No scores available.
Issue body
When a build provider returns an error for a build that failed for
legitimate reasons, handle this on the outer error handler and don't
raise an exception.
Fixes SNAPCRAFT-FK
Fixes SNAPCRAFT-EF
Fixes SNAPCRAFT-E5
Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged CLI update that handles legitimate provider execution errors without raising exceptions. Resolves SNAPCRAFT-FK, SNAPCRAFT-EF, and SNAPCRAFT-E5. Approved by reviewer and merged with 123 additions and 13 deletions across nine files. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged CLI error handler update to gracefully manage legitimate provider execution errors instead of raising exceptions. Resolves SNAPCRAFT-FK, SNAPCRAFT-EF, and SNAPCRAFT-E5. Maintainer requested additional unit tests for the exit handler logic. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Routes legitimate provider exec errors to the CLI outer error handler instead of raising exceptions, fixing SNAPCRAFT-FK, SNAPCRAFT-EF, and SNAPCRAFT-E5. Reviewer requested more unit tests for the exit handler logic prior to merge. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #4295 cli: catch craft-provider errors | snapcraft | merged | Merged after approval, adding CLI error handling for craft-provider failures. Resolves #4262 and CRAFT-1898. Passed CI checks and achieved 100% diff coverage across two modified files. | |
| #4419 cli: catch craft-provider errors | snapcraft | merged | Merged a cherry-picked bugfix to catch craft-provider errors in the CLI. Approved, passed CI, and integrated into the hotfix/7.5 branch after resolving initial dependencies. |