← Back to issue list

project loader: remove special LD_LIBRARY_FLAGS handling for classic

View original Github issue

Metadata

Project
snapcraft
Number
#2484
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #2484 (legacy branch, 2019) dropped the special classic-snap LD_LIBRARY_FLAGS handling in the project loader, which caused libc6 mismatches against the base snap. Same fix landed on master as #2485 (commit a8fce1ae5).

Resolution: closed resolved

Reason: The PR itself was merged after approval by a maintainer, removing the classic-specific LD_LIBRARY_FLAGS/LD_LIBRARY_PATH setup in the project loader and the related unit tests, since library crawling made it unnecessary. The same change was ported to the master branch via PR #2485, committed as a8fce1ae5, referencing LP bug #1817300.

Evaluated by: mr-cal-bot

No scores available.

Issue body

This implementation can cause clashes with changes in the host with regards to the base in use (i.e; core, core18, ...) as their might be libc6 mismatches at the time that can lead to undefined behavior. The issue comes up when the core snap is installed as it is when the libraries are used, this specific behavior is no longer needed as the library crawling feature has improved since this was first introduced. Additionally, the Travis CI job has been moved to using the deb for the time being to overcome the bootstrapping issue that this misbehavior creates. This fix also has to come into legacy first to as snapcraft builds with legacy be LP: #1817300 Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #2484 (legacy branch, 2019) dropped the special classic-snap LD_LIBRARY_FLAGS handling in the project loader, which caused libc6 mismatches against the base snap. Same fix landed on master as #2485 (commit a8fce1ae5).
stealth/space-bunny-alpha — closed resolved Merged PR #2484 removed obsolete classic-snap LD_LIBRARY_FLAGS handling to avoid libc6 mismatches; the same fix was committed as a8fce1ae5 via #2485.
qwen/qwen3.6-35b-a3b — — Merged. Removes obsolete LD_LIBRARY_FLAGS handling causing libc6 mismatches and undefined behavior. Resolves the issue as library crawling improved. Approved by reviewers, passed CI, and temporarily switched CI to deb package.
qwen3.6-35b-a3b-mtp-q6 — — Merged removal of special LD_LIBRARY_FLAGS handling for classic snaps to prevent libc6 mismatches. Improved library crawling made the workaround obsolete. Resolves LP #1817300.

Update history

No update history recorded yet.

Related work

  • Duplicate Of: canonical/snapcraft#2485 (confidence 92%)

    Identical change ('project loader: remove special LD_LIBRARY_FLAGS handling for classic') merged into master as commit a8fce1ae5, since #2484 targeted the legacy branch first.

  • Related To: snapcraft (launchpad)#1817300 (confidence 55%)

    Launchpad bug #1817300 cited in the PR body as the origin of the bootstrapping/libc6 mismatch problem.

Related issues

Issue Project State Summary Similarity
#2485 project loader: remove special LD_LIBRARY_FLAGS handling for classic snapcraft merged Merged in #2485 as a8fce1ae5, removing obsolete classic LD_LIBRARY_FLAGS handling to prevent libc6 mismatches now that library crawling had improved.
90%
#2128 project_loader: stop setting LD_LIBRARY_PATH snapcraft closed Closed unmerged in #2128 as unnecessary after the last known Trusty classic-snap user moved to Xenial; no code was changed.
76%
#1025 project loader: better error message for classic snapcraft merged Merged PR #1025 as commit bfe41e68c, clarifying the project-loader error when classic confinement requires a core snap that is missing.
74%
#1635 snap: remove leaking LD_LIBRARY_PATH snapcraft merged Merged as da9181487: PR #1635 removed LD_LIBRARY_PATH leakage from snapcraft-classic, fixing LP #1723208 and preventing breakage on hosts such as Trusty.
73%