← Back to issue list

project loader: remove special LD_LIBRARY_FLAGS handling for classic

View original Github issue

Metadata

Project
snapcraft
Number
#2485
Type
pull request
State
merged
Author
sergiusens
Labels
Created
Updated
Closed

Current evaluation

Merged removal of special LD_LIBRARY_FLAGS handling for classic snaps to prevent libc6 mismatches and undefined behavior. Improved library crawling made the logic obsolete. Travis CI updated to edge. Approved, CI passed, 7 files changed.

Suggested action:

No scores available.

Issue body

This implementation can cause clashes with changes in the host with regards to the base in use (i.e; core, core18, ...) as their might be libc6 mismatches at the time that can lead to undefined behavior. The issue comes up when the core snap is installed as it is when the libraries are used, this specific behavior is no longer needed as the library crawling feature has improved since this was first introduced. Additionally, the Travis CI job has been moved to using the edge for the time being to overcome the bootstrapping issue that this misbehavior creates. This fix is based on the one introduced in the legacy branch as snapcraft uses the legacy implementation to build itself. LP: #1817300 Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged removal of special LD_LIBRARY_FLAGS handling for classic snaps to prevent libc6 mismatches and undefined behavior. Improved library crawling made the logic obsolete. Travis CI updated to edge. Approved, CI passed, 7 files changed.
qwen3.6-35b-a3b-mtp-q6 Merged removal of special LD_LIBRARY_FLAGS handling for classic project loader to prevent libc6 mismatches and undefined behavior. Improved library crawling made the workaround obsolete. Travis CI updated to edge. Resolves LP #1817300.
qwen3.6-35b-a3b-mtp-q6 Merged removal of special LD_LIBRARY_FLAGS handling for classic snaps to prevent libc6 mismatches and undefined behavior with base snaps. Improved library crawling rendered the workaround obsolete. Travis CI updated to edge; fix adapted from legacy branch.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#2484 project loader: remove special LD_LIBRARY_FLAGS handling for classic snapcraft merged Merged. Removes obsolete LD_LIBRARY_FLAGS handling causing libc6 mismatches and undefined behavior. Resolves the issue as library crawling improved. Approved by reviewers, passed CI, and temporarily switched CI to deb package.
85%
#1025 project loader: better error message for classic snapcraft merged Merged to improve the error message when classic confinement requires the core snap. Resolved Launchpad bug #1650946 after passing CI and review.
72%
#1635 snap: remove leaking LD_LIBRARY_PATH snapcraft merged Removed leaking LD_LIBRARY_PATH from the snapcraft-classic wrapper, resolving Launchpad bug #1723208. The variable leaked into the environment, breaking snaps on distros like Trusty, and was redundant given existing rpaths. Approved and merged.
71%