project loader: remove special LD_LIBRARY_FLAGS handling for classic
Metadata
Current evaluation
Merged in #2485 as a8fce1ae5, removing obsolete classic LD_LIBRARY_FLAGS handling to prevent libc6 mismatches now that library crawling had improved.
Resolution: closed resolved
Reason: PR #2485 was merged as commit a8fce1ae5. It removed the classic-specific library override that could cause host/base libc6 mismatches and undefined behavior.
Evaluated by: mr-cal-bot
No scores available.
Issue body
This implementation can cause clashes with changes in the host with
regards to the base in use (i.e; core, core18, ...) as their might
be libc6 mismatches at the time that can lead to undefined behavior.
The issue comes up when the core snap is installed as it is when
the libraries are used, this specific behavior is no longer needed
as the library crawling feature has improved since this was first
introduced.
Additionally, the Travis CI job has been moved to using the edge
for the time being to overcome the bootstrapping issue that this
misbehavior creates.
This fix is based on the one introduced in the legacy branch
as snapcraft uses the legacy implementation to build itself.
LP: #1817300
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged in #2485 as a8fce1ae5, removing obsolete classic LD_LIBRARY_FLAGS handling to prevent libc6 mismatches now that library crawling had improved. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #2485 (commit a8fce1ae5), removing obsolete classic LD_LIBRARY_FLAGS handling to prevent host libc6 mismatches now that library crawling is improved. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged removal of special LD_LIBRARY_FLAGS handling for classic snaps to prevent libc6 mismatches and undefined behavior. Improved library crawling made the logic obsolete. Travis CI updated to edge. Approved, CI passed, 7 files changed. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged removal of special LD_LIBRARY_FLAGS handling for classic project loader to prevent libc6 mismatches and undefined behavior. Improved library crawling made the workaround obsolete. Travis CI updated to edge. Resolves LP #1817300. |
Update history
No update history recorded yet.
Related work
-
Related To:
snapcraft#2484
(confidence 98%)
Merged legacy-branch counterpart containing the same classic library-handling fix.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2484 project loader: remove special LD_LIBRARY_FLAGS handling for classic | snapcraft | merged | Merged PR #2484 (legacy branch, 2019) dropped the special classic-snap LD_LIBRARY_FLAGS handling in the project loader, which caused libc6 mismatches against the base snap. Same fix landed on master as #2485 (commit a8fce1ae5). | |
| #2128 project_loader: stop setting LD_LIBRARY_PATH | snapcraft | closed | Closed unmerged in #2128 as unnecessary after the last known Trusty classic-snap user moved to Xenial; no code was changed. |