store: handle invalid snap file errors
Metadata
Current evaluation
PR #2492 (cmatsuoka) merged into master as commit 9e83f4575, adding error handling for corrupt/invalid snap files when extracting package data for sign or push, fixing SNAPCRAFT-GE.
Resolution: closed resolved
Reason: The PR was approved and merged into master in commit 9e83f4575 ("store: handle invalid snap file errors (#2492)"), wrapping snap file extraction so corrupt or invalid snap files raise a proper error during signing/push instead of an unhandled exception. Fixes internal SNAPCRAFT-GE.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Properly handle corrupt or invalid snap files when extracting package
data for signing or push.
Fixes SNAPCRAFT-GE
Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | PR #2492 (cmatsuoka) merged into master as commit 9e83f4575, adding error handling for corrupt/invalid snap files when extracting package data for sign or push, fixing SNAPCRAFT-GE. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #2492 in commit 9e83f4575, adding error handling for corrupt or invalid snap files during package-data extraction for signing or push. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged changes implementing error handling for corrupt or invalid snap files during package data extraction for signing or push. Approved by reviewer, passed CI checks, and successfully integrated to master, resolving SNAPCRAFT-GE. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged to properly handle corrupt or invalid snap files during extraction for signing or push, resolving SNAPCRAFT-GE. The change decreased overall coverage by less than 0.01% but was accepted. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1815 repo: handle invalid snaps | snapcraft | merged | Merged PR #1815 in commit 89ce40718: invalid build-snaps now emit clear errors, and snap information fetches retry after network failures. | |
| #5188 fix: improve error message from snapd pack | snapcraft | merged | Merged PR #5188 in commit a9fc44093, improving snapd pack failures by surfacing snapd's error output and fixing snapcraft#4499. | |
| #1110 Show error messages for snap processing errors. | snapcraft | merged | Merged as db92778d5, surfacing Snap Store processing-error details when pushing invalid or duplicate snaps. |