store: handle invalid snap file errors
Metadata
Current evaluation
Merged changes implementing error handling for corrupt or invalid snap files during package data extraction for signing or push. Approved by reviewer, passed CI checks, and successfully integrated to master, resolving SNAPCRAFT-GE.
Suggested action: —
No scores available.
Issue body
Properly handle corrupt or invalid snap files when extracting package
data for signing or push.
Fixes SNAPCRAFT-GE
Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged changes implementing error handling for corrupt or invalid snap files during package data extraction for signing or push. Approved by reviewer, passed CI checks, and successfully integrated to master, resolving SNAPCRAFT-GE. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged to properly handle corrupt or invalid snap files during extraction for signing or push, resolving SNAPCRAFT-GE. The change decreased overall coverage by less than 0.01% but was accepted. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into master. Resolves SNAPCRAFT-GE by properly handling corrupt or invalid snap files during package data extraction for signing or push. Code coverage decreased by less than 0.01% with 84.61% diff coverage. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1815 repo: handle invalid snaps | snapcraft | merged | Merged changes handling invalid snaps in build-snaps with a clear error message. Adds retries to information fetching for improved network failure debugging. Approved after resolving a minor CI typo. | |
| #6098 fix: Tweak error message about SNAPCRAFT_STORE_CREDENTIALS | snapcraft | merged | Merged to clarify the ambiguous SNAPCRAFT_STORE_CREDENTIALS error message. The update explicitly states login fails while the variable is set, resolving user confusion. Approved by four reviewers and passed CI checks prior to merge. | |
| #47 packages: add snap-related exceptions | craft-parts | merged | Added exception classes for snap handling errors to craft_parts.packages.snaps. Approved by two reviewers, passed CI checks, and merged with 163 additions and 18 deletions across two files. | |
| #4 snap: introduce initial snap packaging (CRAFT-578) | rockcraft | merged | Merged initial snap packaging implementation (CRAFT-578). Approved by one reviewer, passed CI checks, and added 86 lines across three files. | |
| #1009 store: implement push pre-check. | snapcraft | merged | Merged into master. Implements a store pre-check for snapcraft push to validate snap registration before upload, preventing failed transfers. Added a user status message, approved by reviewer, and passed CI checks. | |
| #2513 repo: handle deb package fetch error | snapcraft | merged | Merged after approval and CI checks. Implements graceful error handling for failed deb package fetches to prevent crashes, resolving SNAPCRAFT-JE and SNAPCRAFT-JF. Includes copyright date updates. | |
| #5536 fix(store): catch credential decoding errors | snapcraft | merged | Merged fix that catches invalid SNAPCRAFT_STORE_CREDENTIALS decoding errors, replacing internal crashes with user-friendly messages. Updated craft-store dependency to 3.2.2 and resolved issue #5161. |