← Back to issue list

repo: handle invalid snaps

View original Github issue

Metadata

Project
snapcraft
Number
#1815
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #1815 in commit 89ce40718: invalid build-snaps now emit clear errors, and snap information fetches retry after network failures.

Resolution: closed resolved

Reason: PR #1815 was approved and merged as commit 89ce40718, adding friendly validation for invalid build-snaps and retries for snap information requests.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Handle invalid snaps listed under `build-snaps`, provide a nice error. Also add retries to the information fetching logic to be able to have easier debugging information when the network goes wrong. Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #1815 in commit 89ce40718: invalid build-snaps now emit clear errors, and snap information fetches retry after network failures.
stealth/space-bunny-alpha — closed resolved Merged #1815 in commit 89ce40718: invalid build-snaps now produce a clear error, and information fetches retry on network failures.
qwen/qwen3.6-35b-a3b — — Merged changes handling invalid snaps in build-snaps with a clear error message. Adds retries to information fetching for improved network failure debugging. Approved after resolving a minor CI typo.
qwen3.6-35b-a3b-mtp-q6 — — Merged. Implements error handling for invalid build-snaps and adds retries to information fetching for better network error debugging. After resolving a static check failure, the changes were approved and merged.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#2492 store: handle invalid snap file errors snapcraft merged PR #2492 (cmatsuoka) merged into master as commit 9e83f4575, adding error handling for corrupt/invalid snap files when extracting package data for sign or push, fixing SNAPCRAFT-GE.
74%
#1739 fix: fail fast when snap store retries are exhausted for build-snaps craft-parts merged Merged PR #1739; re-raises final non-404 HTTPError after snap store retry exhaustion, preventing silent build-snaps installation skip and surfacing real store failure.
71%
#3502 snaps: do not validate snaps before install/refresh (Fixes LP#1901733) snapcraft merged Merged #3502 (commit 7ab76e084), removing redundant pre-install/refresh validation because store API branch checks already cover it; fixes LP#1901733.
70%