← Back to issue list

cli: cleanup environment detection

View original Github issue

Metadata

Project
snapcraft
Number
#2521
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Merged CLI environment-detection cleanup in snapcore/snapcraft#2521 as commit 351ce3669, changing two files (+23/-21) after maintainer approval.

Resolution: closed resolved

Reason: The approved pull request was merged into snapcraft via commit 351ce3669, completing the environment-detection cleanup.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged CLI environment-detection cleanup in snapcore/snapcraft#2521 as commit 351ce3669, changing two files (+23/-21) after maintainer approval.
stealth/space-bunny-alpha — closed resolved Merged PR #2521 as commit 351ce3669, cleaning up CLI environment detection in two files (+23/-21 lines).
stealth/space-bunny-alpha — closed resolved Merged CLI environment-detection cleanup in canonical/snapcraft#2521 (commit 351ce3669), changing two files by +23/-21 lines with an approved review and no failing CI checks.
qwen/qwen3.6-35b-a3b — — Merged cleanup of CLI environment detection. The pull request modified two files (+23/-21 lines), passed CI checks, and received approval. The refactoring was successfully integrated into the main branch despite a minor Codecov base commit warning.
qwen3.6-35b-a3b-mtp-q6 — — Merged cleanup of CLI environment detection. Passed static and unit tests with 60% diff coverage. Successfully integrated into the main branch by maintainer sergiusens.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#2179 cli: SNAPCRAFT_BUILD_ENVIRONMENT isn't deprecated snapcraft merged Merged PR #2179 (commit 1ff7550be) by kyrofa fixed the conflicting-env-vars error in the CLI, which wrongly named SNAPCRAFT_BUILD_ENVIRONMENT as deprecated; it now correctly names SNAPCRAFT_CONTAINER_BUILDS.
74%