cli: SNAPCRAFT_BUILD_ENVIRONMENT isn't deprecated
Metadata
Current evaluation
Merged into master after approval and CI. Fixed a misleading deprecation warning that incorrectly flagged SNAPCRAFT_BUILD_ENVIRONMENT instead of SNAPCRAFT_CONTAINER_BUILDS. Updated two lines to correct the error message.
Suggested action: —
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh unit`?
-----
SNAPCRAFT_CONTAINER_BUILDS is deprecated, but we have a confusing error message if both are provided, saying that SNAPCRAFT_BUILD_ENVIRONMENT is the one that's deprecated. Fix this to say that SNAPCRAFT_CONTAINER_BUILDS is the one that's deprecated.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged into master after approval and CI. Fixed a misleading deprecation warning that incorrectly flagged SNAPCRAFT_BUILD_ENVIRONMENT instead of SNAPCRAFT_CONTAINER_BUILDS. Updated two lines to correct the error message. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into master. Fixed a CLI error message that incorrectly flagged SNAPCRAFT_BUILD_ENVIRONMENT as deprecated. The update accurately identifies SNAPCRAFT_CONTAINER_BUILDS as the deprecated variable, resolving user confusion. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into master. Corrected a CLI error message that incorrectly flagged SNAPCRAFT_BUILD_ENVIRONMENT as deprecated, clarifying that SNAPCRAFT_CONTAINER_BUILDS is the actual deprecated variable. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2122 many: introduce variables for part src and build | snapcraft | merged | Merged following approval. Introduces new environment variables and replacements for part src and build directories, resolving LP #1763028. Consolidates SNAPCRAFT_* environment handling into a single location. Approved by one reviewer with passing CI checks. | |
| #2130 tests: remove obsolete env var | snapcraft | merged | Merged removal of the obsolete SNAPCRAFT_SEND_ERROR_DATA environment variable from tests following underlying logic deletion. Approved by one reviewer with passing CI checks, the update deletes four lines across one file. | |
| #4307 SNAPCRAFT_BUILD_ENVIRONMENT apparently takes precedence over "--use-lxd" | snapcraft | closed | Fixed via PR #4330. The SNAPCRAFT_BUILD_ENVIRONMENT environment variable no longer overrides the --use-lxd CLI flag. Command line arguments now correctly take precedence over environment variables for build provider selection. | |
| #4041 utils: log envvar SNAPCRAFT_MAX_PARALLEL_BUILD_COUNT when invalid | snapcraft | merged | Merged into main. Adds logging for the SNAPCRAFT_MAX_PARALLEL_BUILD_COUNT environment variable when invalid. Approved by reviewer, passed CI, and contains no functional changes. | |
| #1822265 SNAPCRAFT_BUILD_ENVIRONMENT_* change doesn't apply to existing VMs | snapcraft (launchpad) | closed | Closed without resolution. SNAPCRAFT_BUILD_ENVIRONMENT_* changes failing to apply to existing VMs were left unaddressed with zero comments, indicating the report was abandoned or marked stale. | |
| #1372 cli: Containerbuild clean | snapcraft | merged | Merged to add a unit test and fix for the SNAPCRAFT_CONTAINER_BUILDS=1 clean command. Approved after reviewer testing issues were addressed and a related bug report was linked. |