cli: SNAPCRAFT_BUILD_ENVIRONMENT isn't deprecated
Metadata
Current evaluation
Merged PR #2179 (commit 1ff7550be) by kyrofa fixed the conflicting-env-vars error in the CLI, which wrongly named SNAPCRAFT_BUILD_ENVIRONMENT as deprecated; it now correctly names SNAPCRAFT_CONTAINER_BUILDS.
Resolution: closed resolved
Reason: The PR was approved and merged into master as commit 1ff7550be ("cli: SNAPCRAFT_BUILD_ENVIRONMENT isn't deprecated"), a 2-line change across 2 files (snapcraft/cli.py and its unit tests) correcting the deprecation message for SNAPCRAFT_CONTAINER_BUILDS.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh unit`?
-----
SNAPCRAFT_CONTAINER_BUILDS is deprecated, but we have a confusing error message if both are provided, saying that SNAPCRAFT_BUILD_ENVIRONMENT is the one that's deprecated. Fix this to say that SNAPCRAFT_CONTAINER_BUILDS is the one that's deprecated.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #2179 (commit 1ff7550be) by kyrofa fixed the conflicting-env-vars error in the CLI, which wrongly named SNAPCRAFT_BUILD_ENVIRONMENT as deprecated; it now correctly names SNAPCRAFT_CONTAINER_BUILDS. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #2179 (commit 1ff7550be): the conflict error now correctly identifies SNAPCRAFT_CONTAINER_BUILDS as deprecated, not SNAPCRAFT_BUILD_ENVIRONMENT. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #2179, correcting the deprecation error to flag SNAPCRAFT_CONTAINER_BUILDS instead of the still-supported SNAPCRAFT_BUILD_ENVIRONMENT. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged into master after approval and CI. Fixed a misleading deprecation warning that incorrectly flagged SNAPCRAFT_BUILD_ENVIRONMENT instead of SNAPCRAFT_CONTAINER_BUILDS. Updated two lines to correct the error message. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into master. Fixed a CLI error message that incorrectly flagged SNAPCRAFT_BUILD_ENVIRONMENT as deprecated. The update accurately identifies SNAPCRAFT_CONTAINER_BUILDS as the deprecated variable, resolving user confusion. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #4307 SNAPCRAFT_BUILD_ENVIRONMENT apparently takes precedence over "--use-lxd" | snapcraft | closed | Fixed by merged PR #4329 (commit 7f8d4cff9): --use-lxd now overrides SNAPCRAFT_BUILD_ENVIRONMENT, matching documented precedence. | |
| #2521 cli: cleanup environment detection | snapcraft | merged | Merged CLI environment-detection cleanup in snapcore/snapcraft#2521 as commit 351ce3669, changing two files (+23/-21) after maintainer approval. | |
| #3415 cli: enable SNAPCRAFT_TARGET_ARCH envvar matching --target-arch | snapcraft | closed | Closed unmerged with changes requested. Superseded by merged PR #3414 (ff2cd96bb), which exported SNAPCRAFT_TARGET_ARCH in the project loader's build environment instead of adding a CLI envvar option. | |
| #4329 cli: prioritize `--use-lxd` over `SNAPCRAFT_BUILD_ENVIRONMENT` | snapcraft | merged | Merged PR #4329 (commit 7f8d4cff9) fixes #4307: get_provider() now checks the CLI --use-lxd argument before SNAPCRAFT_BUILD_ENVIRONMENT, matching documented priority. |