Autotools plugin: Call make before make install
Metadata
Current evaluation
Merged a fix for the Autotools plugin to run make before make install, resolving Launchpad bug 1536700. Updated two files with seven additions and three deletions. Reviewer approved without requiring extra integration tests.
Suggested action: —
No scores available.
Issue body
This PR resolves LP: [#1536700](https://bugs.launchpad.net/snapcraft/+bug/1536700) by making the Autotools plugin call `make` before it calls `make install`.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged a fix for the Autotools plugin to run make before make install, resolving Launchpad bug 1536700. Updated two files with seven additions and three deletions. Reviewer approved without requiring extra integration tests. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Updates the Autotools plugin to run make before make install, resolving Launchpad bug #1536700. A dedicated integration test for the full build sequence will be added separately. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged to resolve Launchpad bug #1536700. The Autotools plugin now executes make before make install. No integration tests were added for this change, though future test coverage was noted. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #254 Backport to 1.x: Autotools plugin: Call make before make install | snapcraft | merged | Merged backport of #253 to the 1.x branch, fixing the Autotools plugin to execute make before make install. The 2-file change passed CI and resolved the build sequence issue. | |
| #1076 autotools: extend Make plugin instead of repeating code | snapcraft | merged | Merged into master. Refactored the autotools plugin to extend the existing Make plugin, eliminating duplicated build logic. Approved by one reviewer, passed CI checks, and reduced code by 19 lines across four files. | |
| #351 Autotools plugin: Support installing via prefix. | snapcraft | merged | Merged an autotools plugin update adding a config option to install via prefix instead of DESTDIR, resolving Launchpad bug #1544629. The implementation modifies two files with 120 additions and 7 deletions. | |
| #35 plugins: add autotools plugin | craft-parts | merged | Merged the addition of an autotools plugin for handling ./configure scripts. Approved by two reviewers, the change adds 195 lines across four files, successfully integrating new build system support. | |
| #206 Autotools plugin: Set autogen.sh executable. | snapcraft | merged | Merged. Fixes Launchpad bug #1530995 by ensuring autogen.sh is executable and adds corresponding tests. Approved by sergiusens after commit message formatting adjustments. |