← Back to issue list

Autotools plugin: Call make before make install

View original Github issue

Metadata

Project
snapcraft
Number
#253
Type
pull request
State
merged
Author
kyrofa
Labels
—
Created
Updated
Closed

Current evaluation

PR #253 by kyrofa was merged (merge commit e09cdb58b, change commit bc2213122), making the Autotools plugin run `make` before `make install`, fixing Launchpad bug #1536700.

Resolution: closed resolved

Reason: The PR itself was merged into the mainline via commit bc2213122 ('Autotools plugin: Call make before make install'), wrapped by merge commit e09cdb58b for PR #253, resolving LP bug #1536700. Maintainer comments confirmed the fix was fine without a dedicated example test, with an integration test discussed separately.

Evaluated by: mr-cal-bot

No scores available.

Issue body

This PR resolves LP: [#1536700](https://bugs.launchpad.net/snapcraft/+bug/1536700) by making the Autotools plugin call `make` before it calls `make install`.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved PR #253 by kyrofa was merged (merge commit e09cdb58b, change commit bc2213122), making the Autotools plugin run `make` before `make install`, fixing Launchpad bug #1536700.
stealth/space-bunny-alpha — closed resolved Merged PR #253 updated the Autotools plugin to run make before make install, fixing Launchpad bug #1536700; implementation commit bc2213122.
stealth/space-bunny-alpha — closed resolved Merged PR #253 updated the Autotools plugin to run make before make install, resolving Launchpad bug #1536700 (commit bc2213122).
qwen/qwen3.6-35b-a3b — — Merged a fix for the Autotools plugin to run make before make install, resolving Launchpad bug 1536700. Updated two files with seven additions and three deletions. Reviewer approved without requiring extra integration tests.
qwen3.6-35b-a3b-mtp-q6 — — Merged. Updates the Autotools plugin to run make before make install, resolving Launchpad bug #1536700. A dedicated integration test for the full build sequence will be added separately.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/snapcraft#1076 (confidence 25%)

    Later PR #1076 extended the Make plugin instead of repeating code in autotools, carrying the make-then-install behaviour forward.

  • Caused By: canonical/snapcraft#72 (confidence 20%)

    Earlier autotools commit 'Support installing via prefix' from PR #72 touched the same install logic; not a blocker.

Related issues

Issue Project State Summary Similarity
#1536700 autotools plugin doesn't call make snapcraft (launchpad) closed autotools plugin skipped the build step, running only `make install`. Fixed by canonical/snapcraft PR #253 ("Autotools plugin: Call make before make install"), merged as commit e09cdb58b.
76%
#351 Autotools plugin: Support installing via prefix. snapcraft merged Merged PR #351 by kyrofa adds an Autotools plugin config option to install via prefix instead of DESTDIR, fixing LP bug #1544629 (commit 72dbc3285). Reviewed and approved by sergiusens and come-maiz.
71%