autotools: extend Make plugin instead of repeating code
Metadata
Current evaluation
Merged into master: Autotools was changed to extend the Make plugin and reuse its build flow instead of duplicating logic (commit 83072a5b2).
Resolution: closed resolved
Reason: PR #1076 was approved and merged into master. Commit 83072a5b2 implements the refactor to inherit the existing Make plugin build flow.
Evaluated by: mr-cal-bot
No scores available.
Issue body
We can use the self.make function from make instead of redefining the build process again here.
LP: #1659363
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged into master: Autotools was changed to extend the Make plugin and reuse its build flow instead of duplicating logic (commit 83072a5b2). | |
| stealth/space-bunny-alpha | — | closed resolved | Merged into master: autotools now extends the existing Make plugin, reusing its build flow instead of duplicating logic (#1076, commit 83072a5b2). | |
| qwen/qwen3.6-35b-a3b | — | — | Merged into master. Refactored the autotools plugin to extend the existing Make plugin, eliminating duplicated build logic. Approved by one reviewer, passed CI checks, and reduced code by 19 lines across four files. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into master. Refactored the autotools plugin to extend the Make plugin and reuse the self.make function, eliminating duplicated build logic and slightly improving code coverage. |
Update history
No update history recorded yet.
Related work
-
Related To:
launchpad#1659363
(confidence 95%)
Original Launchpad bug linked in the PR description.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1018 autotools: extend Make plugin instead of repeating code | snapcraft | closed | Closed after inactivity; the same Autotools-to-Make plugin refactor was re-proposed in snapcraft#1076 and merged as commit 83072a5b2. | |
| #1659363 Autotools plugin should inherit make | snapcraft (launchpad) | closed | Superseded by canonical/snapcraft#1076, which merged the Autotools-to-Make plugin refactor in commit 83072a5b2 after #1018 became inactive. | |
| #35 plugins: add autotools plugin | craft-parts | merged | Merged PR #35, adding an Autotools plugin for parts built through the ./configure script; implementation 54b124c8, merge commit 6140b8e6. | |
| #1794777 Update the autotools plugin to be base aware | snapcraft (launchpad) | closed | Autotools became base-aware through merged snapcraft#2363, commit 2f3879d93, adding core16/core18 support for Make, CMake, and Autotools plugins. | |
| #2363 {make,cmake,autotools} plugin: add support for bases | snapcraft | merged | Merged #2363, adding base-aware support for the Make plugin and inherited CMake and Autotools plugins for core16/core18; commit 2f3879d93. | |
| #3398 autotools v2 plugin: support autogen.sh and bootstrap | snapcraft | merged | Merged into master in commit 3fabd01b9, adding autogen.sh and bootstrap script support to the autotools v2 plugin. | |
| #206 Autotools plugin: Set autogen.sh executable. | snapcraft | merged | Merged PR #206 fixed LP #1530995 by making autogen.sh executable when needed and adding Autotools plugin tests (commit 85405240f). |