autotools: extend Make plugin instead of repeating code
Metadata
Current evaluation
Merged into master. Refactored the autotools plugin to extend the existing Make plugin, eliminating duplicated build logic. Approved by one reviewer, passed CI checks, and reduced code by 19 lines across four files.
Suggested action: —
No scores available.
Issue body
We can use the self.make function from make instead of redefining the build process again here.
LP: #1659363
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged into master. Refactored the autotools plugin to extend the existing Make plugin, eliminating duplicated build logic. Approved by one reviewer, passed CI checks, and reduced code by 19 lines across four files. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into master. Refactored the autotools plugin to extend the Make plugin and reuse the self.make function, eliminating duplicated build logic and slightly improving code coverage. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into master. Refactored the autotools plugin to extend the Make plugin, eliminating duplicated build logic. The change resolved LP #1659363 and increased overall code coverage by less than 0.01%. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1018 autotools: extend Make plugin instead of repeating code | snapcraft | closed | Closed due to inactivity after a reviewer requested a bug report and changes. The author responded and added the bug, but a force-push prevented reopening. The reviewer instructed the author to re-propose the pull request. | |
| #35 plugins: add autotools plugin | craft-parts | merged | Merged the addition of an autotools plugin for handling ./configure scripts. Approved by two reviewers, the change adds 195 lines across four files, successfully integrating new build system support. | |
| #253 Autotools plugin: Call make before make install | snapcraft | merged | Merged a fix for the Autotools plugin to run make before make install, resolving Launchpad bug 1536700. Updated two files with seven additions and three deletions. Reviewer approved without requiring extra integration tests. | |
| #3398 autotools v2 plugin: support autogen.sh and bootstrap | snapcraft | merged | Merged into master. Adds autogen.sh and bootstrap script support to the autotools v2 plugin. Approved by reviewer, passed CI, and maintained coverage. | |
| #712 feat(docs): autotools plugin reference | craft-parts | merged | Merged documentation update adding a reference for the autotools plugin. Approved by two reviewers, the change adds 115 lines across three files to expand project documentation. | |
| #533 autotools plugin: support bootstrap parameters | craft-parts | merged | Merged after approval by two reviewers, adding bootstrap parameter support to the autotools plugin. The update modifies four files with 109 additions and 3 deletions, extending build configuration capabilities. | |
| #33 plugins: add make plugin | craft-parts | merged | Merged the addition of a make plugin for building make-based parts. Approved by two reviewers, the change adds 237 lines across five files to extend the plugin system. | |
| #3601 autotools v1 plugin: set correct file permissions for scripts (CRAFT-666) | snapcraft | merged | Merged fix for the autotools v1 plugin correcting file permissions on autogen.sh and bootstrap scripts when they lack executable flags. Code was simplified. Approved by one reviewer and passed CI checks. | |
| #2363 {make,cmake,autotools} plugin: add support for bases | snapcraft | merged | Merged update adds base support (core16, core18) to Make, CMake, and Autotools plugins, resolving three Launchpad bugs. Make plugin tests moved to Spread. Approved, passed CI, and achieved 100% diff coverage. | |
| #999 Updated autotools plugin to use get_build_properties() | snapcraft | merged | Merged into master. The autotools plugin was updated to use get_build_properties(), with corresponding schema test revisions and new tests for get_pull_properties(). Approved, passed CI, and maintained code coverage. |