← Back to issue list

dotnet plugin: fix parsing of newer sdk releases

View original Github issue

Metadata

Project
snapcraft
Number
#2537
Type
pull request
State
merged
Author
ianmetcalf
Labels
Created
Updated
Closed

Current evaluation

Merged into master. The dotnet plugin now parses newer SDK release formats, supporting full URLs and uppercase checksums. Approved by one reviewer, merged with a minor coverage decrease noted by Codecov.

Suggested action:

No scores available.

Issue body

- [X] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? **Couldn't install black - [ ] Have you successfully run `./runtests.sh tests/unit`? **Couldn't get tests to finish ----- In the process of setting up snapcraft for a dotnet core project I ran into an issue when using newer runtime versions. The releases metadata file that is being parsed to find the right sdk file to download has newer releases in a slightly different format. They now include the full URL instead of just the filename. They also changed the checksum file to use upper case instead of lower case letters in the checksum values. You can see this [here](https://raw.githubusercontent.com/dotnet/core/master/release-notes/releases.json) if you compare the releases at the top of the file to the ones lower down. This updates the plugin to handle both release formats. ------ **I'm not developing on an ubuntu machine so running this test suite proved to be a challenge.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged into master. The dotnet plugin now parses newer SDK release formats, supporting full URLs and uppercase checksums. Approved by one reviewer, merged with a minor coverage decrease noted by Codecov.
qwen3.6-35b-a3b-mtp-q6 Merged fix for the dotnet plugin to parse newer SDK release metadata, accommodating full URLs and uppercase checksums. Integrated into master despite a minor coverage decrease and unverified local tests.
qwen3.6-35b-a3b-mtp-q6 Merged into master to fix the dotnet plugin parsing for newer SDK releases, supporting full URLs and uppercase checksums. Integrated despite minor coverage decrease and author test environment constraints.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#2958 dotnet plugin: use the new endpoint for releases snapcraft merged Merged. Updates the dotnet plugin to use a new releases endpoint after the old one was removed. Approved by one reviewer, passed CI checks, and modified two files with 31 additions and 79 deletions.
78%
#2959 dotnet plugin: use the new endpoint for releases snapcraft merged Merged an update to the dotnet plugin to use a new release endpoint after the previous one was removed. Cherry-picked from commit d7de8f5, the change passed CI checks and was merged without review comments.
76%
#3525 dotnet plugin: use https for release metadata url snapcraft merged Merged a single-line update switching the dotnet plugin to HTTPS for the release metadata URL, resolving inaccessibility of the HTTP endpoint. Approved by two reviewers and passed CI.
75%
#2358 dotnet plugin: add support for bases snapcraft merged Merged after reviewer approval, adding base awareness to the DotNet plugin for core16. Passed CI checks and achieved 100% diff coverage across 9 modified files.
72%
#1047 feat: new .NET plugin (v2) craft-parts merged Merged the new .NET plugin (v2). Adjusted dotnet restore to the build step to match craft-parts execution order, resolved CI and linkcheck failures, and incorporated reviewer feedback. Approved by three reviewers and successfully merged.
72%
#330 plugins: Correct docstring in Dotnet plugin craft-parts merged Merged a single-line fix correcting a docstring typo in the Dotnet plugin. Approved by a reviewer, passed CI, and noted as a copy-and-paste error.
70%