← Back to issue list

dotnet plugin: add support for bases

View original Github issue

Metadata

Project
snapcraft
Number
#2358
Type
pull request
State
merged
Author
sergiusens
Labels
Created
Updated
Closed

Current evaluation

Merged after reviewer approval, adding base awareness to the DotNet plugin for core16. Passed CI checks and achieved 100% diff coverage across 9 modified files.

Suggested action:

No scores available.

Issue body

Update the DotNet plugin to be base-aware, only supporting core16. LP: #1794782 Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [ ] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged after reviewer approval, adding base awareness to the DotNet plugin for core16. Passed CI checks and achieved 100% diff coverage across 9 modified files.
qwen3.6-35b-a3b-mtp-q6 Added base support to the DotNet plugin, restricted to core16. The change was merged with 100% diff coverage, updating the plugin to be base-aware per LP #1794782.
qwen3.6-35b-a3b-mtp-q6 Merged. Updated the DotNet plugin to support bases, specifically core16. The change achieved 100% diff coverage and was integrated into the main branch.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#2370 ant plugin: add support for bases snapcraft merged Merged after approval and CI. Adds base support to the ant plugin, restricting it to core16 and core18. Modifies 14 files with 83.54% diff coverage.
80%
#2362 python plugin: add support for bases snapcraft merged Merged. Updated the Python plugin to support core16 and core18 bases. Approved by reviewer, passed CI, and migrated tests to spread with 97.36% coverage.
78%
#2373 rust plugin: add support for bases snapcraft merged Merged update to the Rust plugin adding base support for core16 and core18. Resolves Launchpad bug #1798681. Approved, passed CI, and achieved 100% diff coverage with a net zero line change across 23 files.
78%
#2357 scons plugin: add support for bases snapcraft merged Merged. Updated the Scons plugin to support core16 and core18 bases. Approved by reviewer, passed CI, and modified 105 additions and 18 deletions across five files.
76%
#2368 {kbuild,kernel} plugin: add support for bases snapcraft merged Merged after review and CI approval, adding core16 and core18 base support to the KBuild and Kernel plugins. Resolved Launchpad bugs #1794790 and #1794791 across 7 files with 100% diff coverage.
75%
#2346 ruby plugin: add support for base snapcraft merged Updates the Ruby plugin to be base-aware, restricting support to core16 and core18. Resolves bug LP: #1794800. Merged after approval, passing CI, and 100% diff coverage.
75%
#2366 qmake plugin: add support for bases snapcraft merged Merged update to the qmake plugin adding base support for core16 and core18, resolving LP: #1794799. Includes spread tests, passed CI, and achieved 100% diff coverage.
75%
#2372 gradle plugin: add support for bases snapcraft merged Successfully merged update to the Gradle plugin, restricting base support to core16 and core18. Approved by reviewer, passed CI, and integrated with 448 additions and 108 deletions across 13 files.
74%
#2364 maven plugin: add support for bases snapcraft merged Added base awareness to the Maven plugin, supporting core16 and core18. Merged after reviewer approval and CI checks, resolving Launchpad issue #1794793. Changes modify 18 files with 778 additions and 345 deletions.
74%
#2356 nodejs plugin: add support for bases snapcraft merged Merged update adding base support to the Node.js plugin. Updates npm and yarn invocation to follow standard industry practices. Approved by two reviewers, passed CI, and modified 18 files.
74%