← Back to issue list

catkin spread test: allow python2 as well as python

View original Github issue

Metadata

Project
snapcraft
Number
#2540
Type
pull request
State
merged
Author
kyrofa
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #2540 updated the catkin spread test to accept both python2 and python, matching upstream ROS's use of Python 2.

Resolution: closed resolved

Reason: PR #2540 was merged as commit 70ab7d1a7, changing the catkin spread test to accept either python2 or python.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh tests/unit`? ----- Upstream ROS changed to start using python2. Both are valid, so make sure the test accounts for that.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #2540 updated the catkin spread test to accept both python2 and python, matching upstream ROS's use of Python 2.
stealth/space-bunny-alpha — closed resolved Merged PR #2540 updated the catkin spread test to accept both python2 and python, matching upstream ROS's move to Python 2.
qwen/qwen3.6-35b-a3b — — Merged a one-line catkin spread test update to accept both python2 and python, aligning with upstream ROS changes. Approved, passed CI, and merged with zero coverage impact.
qwen3.6-35b-a3b-mtp-q6 — — Merged changes to the catkin spread test to accept both python2 and python, accommodating upstream ROS updates. Code coverage remained unchanged.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#2547 [legacy] catkin spread test: allow python2 as well as python snapcraft merged PR #2547 merged into the legacy branch as a one-line backport of #2540, letting the catkin spread test accept python2 as well as python. Maintainer noted #2549 was also needed for tests to pass.
83%