← Back to issue list

[legacy] catkin spread test: allow python2 as well as python

View original Github issue

Metadata

Project
snapcraft
Number
#2547
Type
pull request
State
merged
Author
kyrofa
Labels
—
Created
Updated
Closed

Current evaluation

PR #2547 merged into the legacy branch as a one-line backport of #2540, letting the catkin spread test accept python2 as well as python. Maintainer noted #2549 was also needed for tests to pass.

Resolution: closed resolved

Reason: The PR itself was merged with an approving review and a +1/-1 line change to the catkin spread test, backporting the already-merged upstream PR #2540. The author (@kyrofa) confirmed in a closing comment that the companion legacy backport #2549 was required before tests would pass.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh tests/unit`? ----- This PR is a backport of #2540 for legacy.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved PR #2547 merged into the legacy branch as a one-line backport of #2540, letting the catkin spread test accept python2 as well as python. Maintainer noted #2549 was also needed for tests to pass.
stealth/space-bunny-alpha — closed resolved Merged PR #2547, a legacy backport of #2540, allowing the catkin spread test to use either python2 or python. PR #2549 was required for tests to pass.
qwen/qwen3.6-35b-a3b — — Merged as a backport of #2540 for the legacy branch. The update enables the catkin spread test to run with both Python 2 and Python 3. Approved by reviewers and passed CI checks before integration.
qwen3.6-35b-a3b-mtp-q6 — — Merged to legacy as a backport of PR #2540, updating the catkin spread test to support Python 2 alongside Python.

Update history

No update history recorded yet.

Related work

  • Likely Fixed By: snapcraft#2540 (confidence 95%)

    Original non-legacy PR that this change was backported from; also merged, updating the catkin spread test to allow python2 as well as python for upstream ROS's Python 2 move.

  • Related To: snapcraft#2549 (confidence 90%)

    Merged legacy backport of #2548, cited by the author as required before tests would pass.

  • Related To: snapcraft#2548 (confidence 70%)

    Upstream counterpart that #2549 backported; fixes the series used in get_package_version in integration tests.

Related issues

Issue Project State Summary Similarity
#2540 catkin spread test: allow python2 as well as python snapcraft merged Merged PR #2540 updated the catkin spread test to accept both python2 and python, matching upstream ROS's use of Python 2.
83%