extractors: fix typo in appstream icon unit test
Metadata
Current evaluation
Merged a fix for a typo in the appstream icon unit test that duplicated the missing icon scenario. The change ensures the existing icon case is properly validated. Approved by one reviewer, passed CI, and merged into master.
Suggested action: —
No scores available.
Issue body
A typo in the existing icon test in the appstream desktop file fallback
test cases caused the the missing icon scenario to be tested twice. Fix
the test so the existing icon case is also tested.
Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged a fix for a typo in the appstream icon unit test that duplicated the missing icon scenario. The change ensures the existing icon case is properly validated. Approved by one reviewer, passed CI, and merged into master. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into master. Corrected a typo in the appstream icon unit test that duplicated the missing icon scenario, ensuring both missing and existing icon cases are validated. Codecov reported a negligible coverage decrease of less than 0.01%. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a fix for a typo in the appstream icon unit test that duplicated the missing icon scenario. The correction ensures both missing and existing icon cases are validated. Integrated into master with negligible coverage impact. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1853 extractors: support appstream icon and desktop | snapcraft | merged | Merged PR adding AppStream icon and desktop file support to extractors. Approved by two reviewers and passed CI after fixing test failures caused by string casting side effects. Closes issue #1828. |