extractors: fix typo in appstream icon unit test
Metadata
Current evaluation
Merged #2543 (ba7c6e137), fixing an AppStream icon test typo that ran the missing-icon case twice and restored coverage of the existing-icon fallback.
Resolution: closed resolved
Reason: PR #2543 was approved and merged as commit ba7c6e137, correcting the test case so both missing and existing icons are covered.
Evaluated by: mr-cal-bot
No scores available.
Issue body
A typo in the existing icon test in the appstream desktop file fallback
test cases caused the the missing icon scenario to be tested twice. Fix
the test so the existing icon case is also tested.
Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged #2543 (ba7c6e137), fixing an AppStream icon test typo that ran the missing-icon case twice and restored coverage of the existing-icon fallback. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #2543 fixed an appstream icon test typo, restoring coverage of the existing-icon fallback case; merged as commit ba7c6e137. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #2543 fixed a typo that tested the missing appstream icon case twice, restoring coverage for the existing-icon case; merged as ba7c6e137. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #2543 fixed a typo in the appstream desktop-file icon unit test that ran the missing-icon case twice; the existing-icon case is now covered again (commit ba7c6e137). | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #2543 fixes an appstream icon unit-test typo that ran the missing-icon case twice, restoring coverage of the existing-icon case (commit ba7c6e137). | |
| qwen/qwen3.6-35b-a3b | — | — | Merged a fix for a typo in the appstream icon unit test that duplicated the missing icon scenario. The change ensures the existing icon case is properly validated. Approved by one reviewer, passed CI, and merged into master. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into master. Corrected a typo in the appstream icon unit test that duplicated the missing icon scenario, ensuring both missing and existing icon cases are validated. Codecov reported a negligible coverage decrease of less than 0.01%. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2630 appstream extractor: skip non icon file paths | snapcraft | merged | Merged PR #2630 as commit f03d13aa0, updating the AppStream extractor to skip non-icon file paths during icon resolution. |