appstream extractor: skip non icon file paths
Metadata
Current evaluation
Merged PR #2630 as commit f03d13aa0, updating the AppStream extractor to skip non-icon file paths during icon resolution.
Resolution: closed resolved
Reason: PR #2630 was approved and merged into master as commit f03d13aa0. The change filters out non-icon paths when resolving AppStream icons.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Fixes SNAPCRAFT-Y0
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #2630 as commit f03d13aa0, updating the AppStream extractor to skip non-icon file paths during icon resolution. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #2630 as commit f03d13aa0, updating the AppStream extractor to skip icon entries that are not file paths and adding regression coverage. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in PR #2630 as commit f03d13aa0, making the appstream extractor skip non-icon file paths with full diff coverage. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged into master as commit f03d13aa0, making the AppStream extractor skip non-icon file paths and resolving SNAPCRAFT-Y0 with 100% diff coverage. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged into master. The appstream extractor now skips non-icon file paths, resolving SNAPCRAFT-Y0. The change modifies two files (+27/-5 lines), achieved 100% diff coverage, and increased overall coverage by 0.02%. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into master. The appstream extractor now skips non-icon file paths, resolving SNAPCRAFT-Y0. Codecov reported 100% diff coverage and a 0.02% overall coverage increase upon merge. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1853 extractors: support appstream icon and desktop | snapcraft | merged | Merged as commit ce3209468: AppStream extractors now adopt icon and desktop metadata (icon paths, desktop file IDs) from .metainfo.xml. Closes issue #1828. | |
| #2543 extractors: fix typo in appstream icon unit test | snapcraft | merged | Merged #2543 (ba7c6e137), fixing an AppStream icon test typo that ran the missing-icon case twice and restored coverage of the existing-icon fallback. |