kernel plugin: correctly download the os.snap
Metadata
Current evaluation
Merged PR #2566 fixed kernel-plugin os.snap downloads by supplying missing Store API request data and moved tests to spread for cross-base coverage.
Resolution: closed resolved
Reason: PR #2566 was merged into master as commit a3def5fdb, correcting os.snap download requests and adding spread coverage across bases.
Evaluated by: mr-cal-bot
No scores available.
Issue body
The API was missing information for downloads in its requests.
Moving the tests to spread to ensure testing across bases.
LP: #1828843
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #2566 fixed kernel-plugin os.snap downloads by supplying missing Store API request data and moved tests to spread for cross-base coverage. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #2566 fixed kernel-plugin os.snap downloads by supplying missing Store API request data and moved tests to spread for cross-base coverage (a3def5fdb). | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #2566 (commit a3def5fdb) fixed kernel plugin failing to download the os.snap by adding the missing API request parameters, and moved the plugin's tests to spread for cross-base coverage. LP: #1828843. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #2566 as a3def5fdb, fixing kernel plugin os.snap downloads by supplying required API request data and adding spread tests across bases. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #2566 fixed kernel-plugin os.snap downloads by adding missing API request information and moved tests to spread for cross-base coverage. Commit: a3def5fdb. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged into master. Resolved kernel plugin os.snap download failure by adding missing API parameters. Relocated tests to spread for cross-base coverage. Approved, passed CI, and integrated. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into master. Resolves kernel plugin os.snap download failure by correcting missing API request information and relocates tests to spread for cross-base validation. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1606903 kernel plugin: can't snap a kernel using launchpad | snapcraft (launchpad) | closed | Fixed by merged PR canonical/snapcraft#903 (commit 603948e1d), allowing Store part downloads without snapcraft login and resolving Launchpad kernel builds. | |
| #1624 kernel plugin: use latest stable core snap | snapcraft | merged | Merged PR #1624 via commit aa8a8429b, changing the kernel plugin to use the stable core snap instead of obsolete ubuntu-core and updating tests. | |
| #1115 kernel plugin: fix kernel snap layout | snapcraft | merged | Merged via commit 86017cdef: kernel plugin now places modules/ and firmware/ at the top level of prime/ for kernel snaps, plus corrected required build packages; unit and manual tests updated per review. | |
| #1655008 Kernel plugin: Avoid redownloading os.snap on a local Git repo | snapcraft (launchpad) | closed | Closed as won't fix: the legacy core16/core18 kernel plugin behavior only affects Snapcraft 4.x, which receives fixes only for critical bugs. | |
| #1794791 Update the kernel plugin to be base aware | snapcraft (launchpad) | closed | Kernel and KBuild plugins gained base support via merged PR snapcore/snapcraft#2368 (commit ddbda36b5). | |
| #1552168 Add a kernel plugin | snapcraft (launchpad) | closed | Kernel snap creation was implemented by merged canonical/snapcraft#366 (merge b7c1e8bbb, head 6da4ee672), adding kernel and kbuild plugins plus examples. |