kernel plugin: fix kernel snap layout
Metadata
Current evaluation
Merged fix correcting the kernel plugin snap layout for firmware and modules directories, updating required package lists, and addressing review feedback. Approved, passed CI, and merged after CLA verification.
Suggested action: —
No scores available.
Issue body
Hi,
This fixes the kernel snap layout for firmware/ and modules/; I've build tested this against the ONL example linked in the bug and prime/ now properly contains a modules/ and firmware/ toplevel.
(Also small fix to list of required packages; these packages were missing on top of a clean Ubuntu 16.04 EC2 instance)
Cheers,
-- Loïc
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged fix correcting the kernel plugin snap layout for firmware and modules directories, updating required package lists, and addressing review feedback. Approved, passed CI, and merged after CLA verification. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged after CLA verification and test updates. Fixes kernel snap layout for firmware/ and modules/ directories and corrects required packages. Review feedback addressed, including unit test and manual test additions. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged after addressing review feedback. The change corrects the kernel snap layout for firmware and modules directories, updates the required packages list, and adds unit tests. CLA and authorship requirements were resolved prior to merge. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2566 kernel plugin: correctly download the os.snap | snapcraft | merged | Merged into master. Resolved kernel plugin os.snap download failure by adding missing API parameters. Relocated tests to spread for cross-base coverage. Approved, passed CI, and integrated. | |
| #3998 Kernel plugin: multiple fixes | snapcraft | merged | Merged multiple kernel plugin fixes addressing a regression, a crash when no kernel modules are defined, documentation updates, and initramfs overlay warnings. Approved by one reviewer and passed CI checks. | |
| #4200 kernel plugin: change location where snapd deb is unpacked | snapcraft | merged | Merged into hotfix/7.4. The kernel plugin now unpacks the snapd deb package to match ubuntu-core-initramfs expectations. Approved, passed CI, and included unit test fixes. | |
| #4057 Kernel plugin: reapplying missed fixes | snapcraft | merged | Merged after applying missed kernel plugin fixes: crash prevention, docs, warnings, and Ubuntu Core 20 initramfs improvements. Approved, passed CI, and merged with updated unit tests. | |
| #2041 kernel plugin: add kmod as build-package | snapcraft | merged | Merged a kernel plugin fix adding kmod as a build dependency and /sbin to PATH. This resolves missing modprobe errors in Launchpad builders by ensuring required tools are available during snap builds. | |
| #4081 Kernel plugin improvements 1 | snapcraft | merged | Merged after approval. The update reorganizes kernel plugin code by moving implementations to a common module and improves readability with textwrap.dedent. Changes affect 5 files, resulting in a net reduction of 259 lines. | |
| #5640 plugins(ubuntu-kernel): Add new plugin for Ubuntu kernels | snapcraft | merged | Merged to a feature branch. Adds a new Ubuntu kernel plugin standardizing local and product builds. Approved by three reviewers with passing CI. Squash-merged per request, deferring unit tests to a follow-up PR. Implements KE030 spec. | |
| #995 plugins: update kernel plugin to use get_build_properties() | snapcraft | merged | Merged update to the kernel plugin switching it to get_build_properties(), resolving Launchpad bug #1650597. Approved by one reviewer, passed CI, and modified four files with a net coverage increase. | |
| #6255 Feature/kernel initrd plugin merge | snapcraft | merged | Merged after resolving conflicts and aligning with HEAD. Integrates kernel initrd plugin support, requires PR #6254, approved by two reviewers, and passed CI checks. | |
| #1285 kernel plugin: learn how to assemble the ubuntu config using kconfigflavour | snapcraft | merged | Merged. Replaces shell script wrappers in the snapcraft kernel plugin with direct extraction of Ubuntu kernel configs from debian config files using the kconfigflavour parameter. Approved by reviewers and merged after passing CI. |