kernel plugin: fix kernel snap layout
Metadata
Current evaluation
Merged via commit 86017cdef: kernel plugin now places modules/ and firmware/ at the top level of prime/ for kernel snaps, plus corrected required build packages; unit and manual tests updated per review.
Resolution: closed resolved
Reason: The PR was approved and merged into snapcraft (commit 86017cdef), fixing the kernel snap layout so prime/ contains top-level modules/ and firmware/ directories and updating the plugin's required build package list. Review requests (unit tests with FileExists matchers, a manual-tests.md entry) were addressed before merge.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Hi,
This fixes the kernel snap layout for firmware/ and modules/; I've build tested this against the ONL example linked in the bug and prime/ now properly contains a modules/ and firmware/ toplevel.
(Also small fix to list of required packages; these packages were missing on top of a clean Ubuntu 16.04 EC2 instance)
Cheers,
-- Loïc
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged via commit 86017cdef: kernel plugin now places modules/ and firmware/ at the top level of prime/ for kernel snaps, plus corrected required build packages; unit and manual tests updated per review. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in canonical/snapcraft#1115 (commit 86017cdef), fixing kernel snap layout so prime contains top-level modules/ and firmware/ directories and updating required build packages. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged fix correcting the kernel plugin snap layout for firmware and modules directories, updating required package lists, and addressing review feedback. Approved, passed CI, and merged after CLA verification. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged after CLA verification and test updates. Fixes kernel snap layout for firmware/ and modules/ directories and corrects required packages. Review feedback addressed, including unit test and manual test additions. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2566 kernel plugin: correctly download the os.snap | snapcraft | merged | Merged PR #2566 fixed kernel-plugin os.snap downloads by supplying missing Store API request data and moved tests to spread for cross-base coverage. | |
| #1606903 kernel plugin: can't snap a kernel using launchpad | snapcraft (launchpad) | closed | Fixed by merged PR canonical/snapcraft#903 (commit 603948e1d), allowing Store part downloads without snapcraft login and resolving Launchpad kernel builds. | |
| #1624 kernel plugin: use latest stable core snap | snapcraft | merged | Merged PR #1624 via commit aa8a8429b, changing the kernel plugin to use the stable core snap instead of obsolete ubuntu-core and updating tests. | |
| #1675029 kernel plugin: the modprobe output parsing is wrong | snapcraft (launchpad) | closed | Fixed by merged PR snapcraft/snapcraft#1208 (commit 6c8d85ee3), correcting kernel-plugin modprobe parsing to use the module path from the second output item. | |
| #1552168 Add a kernel plugin | snapcraft (launchpad) | closed | Kernel snap creation was implemented by merged canonical/snapcraft#366 (merge b7c1e8bbb, head 6da4ee672), adding kernel and kbuild plugins plus examples. | |
| #1658177 snapcraft kernel plugin puts module and firmware under 15.04-era lib/ directory | snapcraft (launchpad) | closed | Kernel snap layout was fixed: modules/ and firmware/ are now placed at the snap root by snapcraft PR #1115, merged as commit 86017cdef. | |
| #1794791 Update the kernel plugin to be base aware | snapcraft (launchpad) | closed | Kernel and KBuild plugins gained base support via merged PR snapcore/snapcraft#2368 (commit ddbda36b5). | |
| #1627923 kernel plugin initrd packaging fails when kernel modules have common dependencies | snapcraft (launchpad) | closed | Fixed by snapcore/snapcraft PR #837, which allowed initrd packaging to handle common kernel-module dependencies without duplicate-copy failures. | |
| #366 New plugin: kernel | snapcraft | merged | Merged PR #366 by sergiusens into master via merge commit b7c1e8bbb (head commit 6da4ee672), adding the new kernel and kbuild snapcraft plugins with two example projects, closing LP #1552168. | |
| #6418 core26: kernel plugin fails to run | snapcraft | closed | Fixed by merged PR canonical/snapcraft#6425 (commit be405aad6), updating the kernel plugin to handle modules packaged under usr/lib on usrmerged core26 systems. |