pluginhandler: honour symlink directory paths for filesets (LP: #1833408)
Metadata
Current evaluation
Merged fix for symlink directory path handling in filesets, resolving usr-merge issues. Added regression tests, corrected faulty tests, and retained the follow_symlinks flag per reviewer request. Approved and passed CI.
Suggested action: —
No scores available.
Issue body
Addresses the usr-merge issues discussed at https://bugs.launchpad.net/snapcraft/+bug/1833408
Adds tests to reproduce issue, fixup/remove faulty tests that are exposed with these changes.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged fix for symlink directory path handling in filesets, resolving usr-merge issues. Added regression tests, corrected faulty tests, and retained the follow_symlinks flag per reviewer request. Approved and passed CI. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Fixed symlink directory handling in filesets for usr-merge issue LP #1833408. Added regression tests and corrected faulty ones. The follow_symlinks flag in _migrate_files was retained to preserve existing test behavior. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged fix for symlink directory path handling in filesets, resolving usr-merge issues. Added regression tests and corrected related faulty tests. The follow_symlinks flag in _migrate_files was retained per maintainer request to prevent test breakage. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3406 pluginhandler: do not walk symlinks for include filesets | snapcraft | merged | Merged fix prevents snapcraft from incorrectly traversing symlinks during include fileset generation. Checks targets before walking to resolve filtering issues for symlinked directories. Approved, passed CI, and merged. | |
| #2481 meta: handle symlinked hooks (#2478) | snapcraft | merged | Merged a fix for a regression in symlinked hook handling that caused FileNotFoundErrors during permission changes. Approved by reviewer, passed CI, and updated 2 files to safely resolve symlinks before stat operations. | |
| #3497 repo: fix regression in fix_symlink() | snapcraft | merged | Merged a fix for a regression in fix_symlink() where copied files retained stale symlinks. The update ensures symlinks correctly point to new files and adds spread tests for relative and host copy scenarios. Approved by two reviewers and passed CI. | |
| #2478 meta: handle symlinked hooks | snapcraft | merged | Merged PR #2478 resolves a regression from #2440 that broke symlinked hooks. The fix prevents FileNotFoundErrors during permission changes by properly resolving symlinks before stat operations. Approved, passed CI, and merged into master. |