pluginhandler: honour symlink directory paths for filesets (LP: #1833408)
Metadata
Current evaluation
Merged as 3f5799a72, making filesets honor symlink directory paths and fixing LP #1833408; regression tests were added and faulty tests corrected.
Resolution: closed resolved
Reason: PR snapcraft#2628 was merged as commit 3f5799a72. Its pluginhandler changes resolved symlink-directory path handling for filesets.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Addresses the usr-merge issues discussed at https://bugs.launchpad.net/snapcraft/+bug/1833408
Adds tests to reproduce issue, fixup/remove faulty tests that are exposed with these changes.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged as 3f5799a72, making filesets honor symlink directory paths and fixing LP #1833408; regression tests were added and faulty tests corrected. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged as 3f5799a72: filesets now honor symlink directory paths, addressing LP: #1833408. Added regression tests and corrected faulty tests. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged fix for symlink directory path handling in filesets, resolving usr-merge issues. Added regression tests, corrected faulty tests, and retained the follow_symlinks flag per reviewer request. Approved and passed CI. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Fixed symlink directory handling in filesets for usr-merge issue LP #1833408. Added regression tests and corrected faulty ones. The follow_symlinks flag in _migrate_files was retained to preserve existing test behavior. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3406 pluginhandler: do not walk symlinks for include filesets | snapcraft | merged | Merged #3406 as commit 63c2c7a7f, adding a symlink check before include-fileset traversal so external links no longer bypass filtering of target directories. | |
| #1064 pluginhandler: collide with directories and symlinks | snapcraft | merged | Merged #1064 via commit d4b104887, adding directories and symlinks to pluginhandler collision detection, including conflicting symlink targets; fixes LP #1658225. |