← Back to issue list

unit tests: make lifecycle tests more robust

View original Github issue

Metadata

Project
snapcraft
Number
#2637
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #2637 made lifecycle unit tests more robust by relaxing message-output checks, preventing fake webserver messages from causing false failures.

Resolution: closed resolved

Reason: PR #2637 was approved and merged into snapcraft, delivering the more flexible lifecycle-test message checks described in the pull request.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Some fake webserver messages can sneak into the checked for message output, using a more flexible check avoids this situation. Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #2637 made lifecycle unit tests more robust by relaxing message-output checks, preventing fake webserver messages from causing false failures.
stealth/space-bunny-alpha — closed resolved Merged PR #2637 made lifecycle unit tests more robust by relaxing message-output checks, preventing fake webserver messages from causing false failures.
qwen/qwen3.6-35b-a3b — — Merged updates to improve lifecycle unit test robustness. Replaced strict message assertions with flexible checks to prevent fake webserver output from causing false failures. Approved and passed CI.
qwen3.6-35b-a3b-mtp-q6 — — Merged lifecycle test updates that replace strict message assertions with flexible checks, preventing fake webserver output from causing false failures. Codecov reported missing base coverage, but the changes were successfully integrated.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#2163 tests: add lifecycle ordering tests snapcraft merged Merged in #2163 via commit efebd07e9, adding lifecycle-ordering tests and refactoring lifecycle tests into a dedicated package; Codecov reported 100% diff coverage.
70%