tests: add lifecycle ordering tests
Metadata
Current evaluation
Merged changes adding lifecycle ordering tests and refactoring them into a dedicated package. Approved by a reviewer, passed CI checks, and increased code coverage by 0.02%.
Suggested action: —
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh unit`?
-----
Also, generally refactor the lifecycle tests into their own package.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged changes adding lifecycle ordering tests and refactoring them into a dedicated package. Approved by a reviewer, passed CI checks, and increased code coverage by 0.02%. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into master. Added lifecycle ordering tests and refactored lifecycle tests into a dedicated package. Coverage increased by 0.02% with 100% diff coverage. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into master. Added lifecycle ordering tests and refactored lifecycle tests into a dedicated package. Increased overall coverage by 0.02% with 100% diff coverage. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3719 tests: fix lifecycle tests to run on new directory | snapcraft | merged | Merged a fix for lifecycle tests to run in a new directory instead of the current one. Approved by a reviewer, passed CI, and changed three lines. | |
| #3024 tests: remove usage of FakeApt fixtures in lifecycle | snapcraft | merged | Merged changes replacing FakeApt fixtures in lifecycle tests with targeted mock.patch calls and related cleanup. Approved by one reviewer and passed CI checks. | |
| #4584 lifecycle commands | snapcraft | merged | Merged implementation of lifecycle commands. Approved by two reviewers, passed all CI checks, and modified 15 files with full test coverage. | |
| #2637 unit tests: make lifecycle tests more robust | snapcraft | merged | Merged updates to improve lifecycle unit test robustness. Replaced strict message assertions with flexible checks to prevent fake webserver output from causing false failures. Approved and passed CI. | |
| #4452 test(spread): check for new lifecycle message | snapcraft | merged | Merged a test update to verify a new lifecycle message, resolving a regression from #4431. Approved by two reviewers with passing CI and stable coverage. The fix unblocks PR #4450. | |
| #265 lifecycle_manager: minor primed packages sort refactoring | craft-parts | merged | Merged a minor refactoring to fix list sorting in lifecycle_manager after debug instrumentation was removed. Approved by one reviewer, passed CI checks, and applied with a +1/-3 line change. | |
| #1626 lifecycle: split into its own package | snapcraft | merged | Merged a refactor splitting the lifecycle module into a dedicated package to improve code manageability and separation of concerns. Approved by reviewers with passing CI checks. | |
| #3162 tests: remove scenario usage from lifecycle order | snapcraft | merged | Merged following approval and passing CI. Removes scenario usage from lifecycle order tests to facilitate the pytest transition. Modified one file with 777 additions and 370 deletions. | |
| #83 tests: test lifecycle.py::_run_in_provider | rockcraft | merged | Merged unit tests for lifecycle.py::_run_in_provider(), increasing coverage from 16% to 36%. Approved by one reviewer, passed CI, and added 144 lines across three files. | |
| #29 commands: add basic lifecycle commands | craft-application | merged | Merged after two approvals and passing CI. Adds basic lifecycle commands across eight files, introducing 748 lines and removing 11. Maintains 100 percent test coverage. |