← Back to issue list

tests: add lifecycle ordering tests

View original Github issue

Metadata

Project
snapcraft
Number
#2163
Type
pull request
State
merged
Author
kyrofa
Labels
—
Created
Updated
Closed

Current evaluation

Merged in #2163 via commit efebd07e9, adding lifecycle-ordering tests and refactoring lifecycle tests into a dedicated package; Codecov reported 100% diff coverage.

Resolution: closed resolved

Reason: PR #2163 was approved and merged as commit efebd07e9, completing the lifecycle-ordering test coverage and test-package refactor described in the PR.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh unit`? ----- Also, generally refactor the lifecycle tests into their own package.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged in #2163 via commit efebd07e9, adding lifecycle-ordering tests and refactoring lifecycle tests into a dedicated package; Codecov reported 100% diff coverage.
stealth/space-bunny-alpha — closed resolved Merged in #2163 (efebd07e), adding lifecycle ordering tests and refactoring them into a dedicated package; Codecov reported 0.02% coverage growth.
qwen/qwen3.6-35b-a3b — — Merged changes adding lifecycle ordering tests and refactoring them into a dedicated package. Approved by a reviewer, passed CI checks, and increased code coverage by 0.02%.
qwen3.6-35b-a3b-mtp-q6 — — Merged into master. Added lifecycle ordering tests and refactored lifecycle tests into a dedicated package. Coverage increased by 0.02% with 100% diff coverage.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#3719 tests: fix lifecycle tests to run on new directory snapcraft merged Merged PR #3719 via commit 314dd7574 to run lifecycle tests in a new directory instead of the current directory.
75%
#2057 tests: extract lifecycle suite from general suite snapcraft merged Merged PR #2057 as commit 59bdc3343, splitting lifecycle tests from the oversized general suite to prevent Travis timeouts.
73%
#57 test: unit tests for lifecycle service debcraft open Adds unit tests for the Lifecycle service, but tests a helper (_get_prime_dirs_from_project) deleted by merged #68 and collides with the existing test_lifecycle.py from #139; needs a rewrite, not a rebase. CI: conventional-commits policy, lint and OSV-scanner failing.
72%
#50 add unit tests for lifecycle.py rockcraft closed Added tests/unit/test_lifecycle.py covering lifecycle.py's pack paths (mainly _run_in_provider) in PR #83, commit 2f5b9c48; maintainer closed the issue pointing to that commit.
72%
#3162 tests: remove scenario usage from lifecycle order snapcraft merged Merged as commit 58c66b7a7, dropping testscenarios usage from the lifecycle-order unit tests as groundwork for the move to pytest, which landed separately in #3167.
71%
#2637 unit tests: make lifecycle tests more robust snapcraft merged Merged PR #2637 made lifecycle unit tests more robust by relaxing message-output checks, preventing fake webserver messages from causing false failures.
70%
#626 refactor: move the test command to lifecycle craft-application merged Merged PR #626 moved testing into the lifecycle after pack and passed packed-artifact state to spread tests.
70%