← Back to issue list

Make plugin: Support non-standard makefile name.

View original Github issue

Metadata

Project
snapcraft
Number
#264
Type
pull request
State
merged
Author
kyrofa
Labels
—
Created
Updated
Closed

Current evaluation

Merged a change adding a makefile property to the Make plugin, enabling custom makefile names. The author added integration tests without mocks per reviewer feedback. Resolves Launchpad bug #1500759.

Suggested action: —

No scores available.

Issue body

This PR fixes LP: [#1500759](https://bugs.launchpad.net/snapcraft/+bug/1500759) by adding a "makefile" property to the Make plugin, which, if specified, results in a `make -f <makefile>` instead of just `make`. This supports projects with makefiles named e.g. makefile.linux, etc.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b — — Merged a change adding a makefile property to the Make plugin, enabling custom makefile names. The author added integration tests without mocks per reviewer feedback. Resolves Launchpad bug #1500759.
qwen3.6-35b-a3b-mtp-q6 — — Merged PR adding a makefile property to the Make plugin, enabling custom makefile names via make -f. Resolves Launchpad bug #1500759. Integration tests were added per reviewer feedback prior to merge.
qwen3.6-35b-a3b-mtp-q6 — — Merged following integration test additions. Adds a makefile property to the Make plugin, passing custom filenames to make -f. Resolves Launchpad bug #1500759.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#265 Backport to 1.x: Make plugin: Support non-standard makefile name. snapcraft merged Merged backport of #264 to the 1.x branch, adding support for non-standard makefile names in the Make plugin. Integration test conflicts were resolved to match 1.x plainbox types. The change modifies 7 files.
72%
#1387 test: add integration tests for make plugin craft-parts merged Merged integration tests for the make plugin covering basic functionality and parameter forwarding. Addressed review feedback by refactoring tests, fixing DESTDIR failures, and updating commit messages. Resolved conflicts and passed CI.
70%
#992 plugins: update make plugin to use get_build_properties() snapcraft merged Merged into master. Updated the make plugin to use get_build_properties() and added corresponding tests. Approved by a reviewer, passed CI checks, and resolved Launchpad bug 1650548.
70%