← Back to issue list

Make plugin: Support non-standard makefile name.

View original Github issue

Metadata

Project
snapcraft
Number
#264
Type
pull request
State
merged
Author
kyrofa
Labels
—
Created
Updated
Closed

Current evaluation

Merged in #264 via ef982f26f (merge 5031c11d9), adding a makefile property to the Make plugin so make uses the specified filename. Resolves LP #1500759.

Resolution: closed resolved

Reason: Commit ef982f26f added a Make plugin makefile property that invokes make -f <makefile>, resolving LP #1500759. It was merged by #264 in merge commit 5031c11d9.

Evaluated by: mr-cal-bot

No scores available.

Issue body

This PR fixes LP: [#1500759](https://bugs.launchpad.net/snapcraft/+bug/1500759) by adding a "makefile" property to the Make plugin, which, if specified, results in a `make -f <makefile>` instead of just `make`. This supports projects with makefiles named e.g. makefile.linux, etc.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged in #264 via ef982f26f (merge 5031c11d9), adding a makefile property to the Make plugin so make uses the specified filename. Resolves LP #1500759.
stealth/space-bunny-alpha — closed resolved Merged as #264 via ef982f26f, adding a makefile property so the Make plugin runs make -f <makefile>; resolves LP #1500759.
stealth/space-bunny-alpha — closed resolved Merged in #264 via ef982f26f (merge 5031c11d9), adding a makefile property to the Make plugin so make uses a specified filename. Resolves LP #1500759.
qwen/qwen3.6-35b-a3b — — Merged a change adding a makefile property to the Make plugin, enabling custom makefile names. The author added integration tests without mocks per reviewer feedback. Resolves Launchpad bug #1500759.
qwen3.6-35b-a3b-mtp-q6 — — Merged PR adding a makefile property to the Make plugin, enabling custom makefile names via make -f. Resolves Launchpad bug #1500759. Integration tests were added per reviewer feedback prior to merge.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#265 Backport to 1.x: Make plugin: Support non-standard makefile name. snapcraft merged Merged #265 into the 1.x branch, backporting #264 so the Make plugin accepts a configured non-standard makefile filename.
76%