← Back to issue list

Backport to 1.x: Make plugin: Support non-standard makefile name.

View original Github issue

Metadata

Project
snapcraft
Number
#265
Type
pull request
State
merged
Author
kyrofa
Labels
Created
Updated
Closed

Current evaluation

Merged backport of #264 to the 1.x branch, adding support for non-standard makefile names in the Make plugin. Integration test conflicts were resolved to match 1.x plainbox types. The change modifies 7 files.

Suggested action:

No scores available.

Issue body

Backport of #264 for 1.x. - Conflicts: - integration_tests/test_make_plugin.py: Resolved by making integration test conform to 1.x plainbox types.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged backport of #264 to the 1.x branch, adding support for non-standard makefile names in the Make plugin. Integration test conflicts were resolved to match 1.x plainbox types. The change modifies 7 files.
qwen3.6-35b-a3b-mtp-q6 Merged backport of PR #264 to the 1.x branch, enabling the make plugin to support non-standard makefile names. Integration test conflicts were resolved by adapting the test to 1.x plainbox types.
qwen3.6-35b-a3b-mtp-q6 Merged backport of #264 to the 1.x branch, enabling the make plugin to support non-standard makefile names. Integration test conflicts were resolved by adapting them to 1.x plainbox types.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#254 Backport to 1.x: Autotools plugin: Call make before make install snapcraft merged Merged backport of #253 to the 1.x branch, fixing the Autotools plugin to execute make before make install. The 2-file change passed CI and resolved the build sequence issue.
77%
#347 Backport to 1.x: CMake plugin: Automatically find staged libs and files. snapcraft merged Merged a backport of #345 to the 1.x branch. The CMake plugin now automatically locates staged libraries and files, updating two files with 62 additions and 7 deletions. A minor lint warning was noted but did not block integration.
74%
#264 Make plugin: Support non-standard makefile name. snapcraft merged Merged a change adding a makefile property to the Make plugin, enabling custom makefile names. The author added integration tests without mocks per reviewer feedback. Resolves Launchpad bug #1500759.
72%