← Back to issue list

Backport to 1.x: Make plugin: Support non-standard makefile name.

View original Github issue

Metadata

Project
snapcraft
Number
#265
Type
pull request
State
merged
Author
kyrofa
Labels
—
Created
Updated
Closed

Current evaluation

Merged #265 into the 1.x branch, backporting #264 so the Make plugin accepts a configured non-standard makefile filename.

Resolution: closed resolved

Reason: PR #265 was merged and backported the Make plugin enhancement from #264, adapting the integration test to 1.x plainbox types. The original implementation landed as commit ef982f26f via merge 5031c11d9.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Backport of #264 for 1.x. - Conflicts: - integration_tests/test_make_plugin.py: Resolved by making integration test conform to 1.x plainbox types.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged #265 into the 1.x branch, backporting #264 so the Make plugin accepts a configured non-standard makefile filename.
stealth/space-bunny-alpha — closed resolved Merged #265 into 1.x, backporting #264 to support non-standard Makefile filenames; integration tests were adapted for 1.x plainbox types.
stealth/space-bunny-alpha — closed resolved Merged into the 1.x branch as canonical/snapcraft#265, backporting #264 to support custom Makefile names; integration tests were adapted to 1.x plainbox types.
qwen/qwen3.6-35b-a3b — — Merged backport of #264 to the 1.x branch, adding support for non-standard makefile names in the Make plugin. Integration test conflicts were resolved to match 1.x plainbox types. The change modifies 7 files.
qwen3.6-35b-a3b-mtp-q6 — — Merged backport of PR #264 to the 1.x branch, enabling the make plugin to support non-standard makefile names. Integration test conflicts were resolved by adapting the test to 1.x plainbox types.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/snapcraft#264 (confidence 100%)

    Original PR containing the merged non-standard Makefile-name support that #265 backported to 1.x.

Related issues

Issue Project State Summary Similarity
#264 Make plugin: Support non-standard makefile name. snapcraft merged Merged in #264 via ef982f26f (merge 5031c11d9), adding a makefile property to the Make plugin so make uses the specified filename. Resolves LP #1500759.
76%