← Back to issue list

Plugin catkin: forward parallel build count

View original Github issue

Metadata

Project
snapcraft
Number
#2669
Type
pull request
State
merged
Author
artivis
Labels
Created
Updated
Closed

Current evaluation

Merged. The catkin plugin now forwards parallel-build-count and disable-parallel options to the build command. Approved by three reviewers, passed CI checks, and replaces PR #2665.

Suggested action:

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh tests/unit`? ----- Plugin catkin : forward the `parallel-build-count`/`disable-parallel` options down to the build invocation command. Replace #2665

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged. The catkin plugin now forwards parallel-build-count and disable-parallel options to the build command. Approved by three reviewers, passed CI checks, and replaces PR #2665.
qwen3.6-35b-a3b-mtp-q6 Merged into master. The catkin plugin now forwards parallel-build-count and disable-parallel options to the build invocation command, replacing PR #2665. All tests passed with 100% diff coverage.
qwen3.6-35b-a3b-mtp-q6 Merged into master. The catkin plugin now forwards parallel-build-count and disable-parallel options to the build command, replacing PR #2665. Changes achieved 100% diff coverage and were integrated into main.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#2733 cmake plugin: support disable-parallel option snapcraft merged Merged. Updated the cmake plugin to inherit parallel_build_count from BasePlugin, enabling the disable-parallel option. Approved by reviewers, passed CI checks, and includes unit tests.
79%
#2670 Plugin colcon: forward parallel build count snapcraft merged Forwarded parallel build options to the colcon plugin. Initial CI failed due to an unrecognized --parallel-workers argument, resolved via follow-up PR #2677 and test restarts. Successfully merged after passing reviews and CI.
74%
#2665 Plugin catkin: disable parallel option snapcraft closed A proposed disable parallel option for the catkin plugin was closed without merging. Reviewers requested changes with four unresolved comments, leaving the contribution abandoned.
73%
#517 fix: set correct parallel build count in scripts craft-application merged Merged fix to set the correct parallel build count in build scripts. Replaced PR #509 by cherry-picking commits after retargeting conflicts. Approved by two reviewers, passed CI, and resolved CRAFT-3524.
72%
#3756 parts: fix parallel build count snapcraft merged Merged fix for parallel build count in craft-part. Dynamically configures concurrent jobs based on host capabilities. Approved by two reviewers, passed CI, and increased coverage by 0.08%.
71%