← Back to issue list

Plugin colcon: forward parallel build count

View original Github issue

Metadata

Project
snapcraft
Number
#2670
Type
pull request
State
merged
Author
artivis
Labels
—
Created
Updated
Closed

Current evaluation

Merged as bd0480688; the colcon plugin now forwards parallel-build-count and disable-parallel settings to the colcon build command.

Resolution: closed resolved

Reason: PR #2670 was approved and merged, adding the missing colcon build arguments. Follow-up PR #2677 separately fixed command-output quoting exposed during testing.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh tests/unit`? ----- Plugin colcon : forward the `parallel-build-count`/`disable-parallel` options down to the build invocation command.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged as bd0480688; the colcon plugin now forwards parallel-build-count and disable-parallel settings to the colcon build command.
stealth/space-bunny-alpha — closed resolved Merged as commit bd0480688 via #2670, forwarding parallel-build-count/disable-parallel options to colcon builds. Follow-up #2677 addressed command-output quoting exposed during testing.
stealth/space-bunny-alpha — closed resolved Merged #2670 (bd0480688), forwarding parallel-build-count and disable-parallel options to colcon build. Follow-up #2677 fixed quote handling in plugin command-error output exposed by spread tests.
stealth/space-bunny-alpha — closed resolved Merged as bd0480688, forwarding parallel-build-count and disable-parallel to colcon builds. Follow-up #2677 (098e7d5d5) fixed quote preservation in failed-command diagnostics exposed during testing.
qwen/qwen3.6-35b-a3b — — Forwarded parallel build options to the colcon plugin. Initial CI failed due to an unrecognized --parallel-workers argument, resolved via follow-up PR #2677 and test restarts. Successfully merged after passing reviews and CI.
qwen3.6-35b-a3b-mtp-q6 — — Merged. Forwards parallel build options to colcon. Tests failed due to an unrecognized --parallel-workers argument and timeouts. After restarting tests and opening follow-up PR #2677 to fix the error, the change was merged.

Update history

No update history recorded yet.

Related work

  • Related To: snapcraft#2677 (confidence 95%)

    Merged follow-up that preserved quotes when displaying failed colcon commands.

Related issues

Issue Project State Summary Similarity
#2669 Plugin catkin: forward parallel build count snapcraft merged Merged as commit 6c3e3ab9a, forwarding parallel-build-count and disable-parallel options to catkin build commands and replacing #2665.
75%
#3638 colcon v2: forward cmake args snapcraft merged Merged PR #3638 (commit 66e385a17), forwarding colcon-cmake-args to Colcon v2's build command for plain CMake packages.
73%
#2486 colcon plugin: support build-time chaining snapcraft merged Merged #2486 as 60c3c9b18, restoring colcon build-time workspace chaining through setup files; fixes LP #1816565.
72%