← Back to issue list

meta: decouple DesktopFile logic

View original Github issue

Metadata

Project
snapcraft
Number
#2684
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Merged refactoring that relocates DesktopFile to meta.desktop, decouples ExtractedMetadata, and simplifies gui_dir handling. The change touches 3 files, adds 173 net lines, and increases unit test coverage by 0.07%.

Suggested action: —

No scores available.

Issue body

- move DesktopFile to meta.desktop - Decouple ExtractedMetadata from DesktopFile. - Pass gui_dir to .write instead of figuring it out in-method. Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b — — Merged refactoring that relocates DesktopFile to meta.desktop, decouples ExtractedMetadata, and simplifies gui_dir handling. The change touches 3 files, adds 173 net lines, and increases unit test coverage by 0.07%.
qwen3.6-35b-a3b-mtp-q6 — — Merged into master. Refactored DesktopFile logic by moving it to meta.desktop, decoupling ExtractedMetadata, and passing gui_dir explicitly. Achieved 100% diff coverage and a 0.07% overall coverage increase.
qwen3.6-35b-a3b-mtp-q6 — — Merged into master. Refactored DesktopFile logic by relocating it to meta.desktop, decoupling ExtractedMetadata, and passing gui_dir explicitly to the write method. Unit test coverage increased by 0.07%.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#2722 meta: fixes for desktop file handling snapcraft merged Merged changes fixing desktop file handling for multiple sections and preserving Exec= arguments. Updates span two files (+101/-21 lines), approved by a reviewer with passing CI checks.
76%