← Back to issue list

extensions: rename extension classes to known names

View original Github issue

Metadata

Project
snapcraft
Number
#2705
Type
pull request
State
merged
Author
sergiusens
Labels
Created
Updated
Closed

Current evaluation

Merged changes renaming extension classes to known names, simplifying logic by removing string parsing for Extension class implementation. Approved, passed CI, and increased coverage by 0.01% across five files.

Suggested action:

No scores available.

Issue body

This simplifies the logic and removes the need to parse strings to get the implementation of the Extension class. Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged changes renaming extension classes to known names, simplifying logic by removing string parsing for Extension class implementation. Approved, passed CI, and increased coverage by 0.01% across five files.
qwen3.6-35b-a3b-mtp-q6 Merged into master. Renamed extension classes to known names, simplifying logic and eliminating string parsing for Extension class implementation. The change increased overall code coverage by 0.01% with 100% diff coverage.
qwen3.6-35b-a3b-mtp-q6 Merged into master. Renames extension classes to standard names, simplifying logic and removing string parsing for class resolution. Code coverage increased by 0.01%.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#3781 extensions: refactor snapcraft merged Merged refactoring of extensions to prevent future cyclic import issues. Approved by reviewer, passed CI, and integrated into main. Reduced code by 163 lines across six files with a minor coverage decrease.
76%
#2355 extensions: cleanup and generic tests snapcraft merged Resolved LP: #1791172 by ensuring extensions are properly installable and adding generic smoke tests for future extensions. Merged after approval and passing CI, modifying 10 files (+133/-17).
73%
#2350 extensions: parse all declared extensions before applying snapcraft merged Merged to resolve LP: #1797638 by parsing all declared extensions before applying them, fixing conflicts when multiple apps share an extension. Approved, passed CI, and achieved 100% diff coverage.
72%
#2233 templates: rename to extensions snapcraft merged Merged rename of templates to extensions across 21 files, resolving Launchpad bug #1789935. No functional changes were made. Approved by a maintainer, passed CI checks, and maintained 95.65% code coverage.
72%