← Back to issue list

tests: completely mock mercurial tests

View original Github issue

Metadata

Project
snapcraft
Number
#2714
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #2714 completely mocked Mercurial unit tests to speed them up while retaining integration coverage; implemented in commit f22b5b07b.

Resolution: closed resolved

Reason: PR #2714 was merged and implemented by commit f22b5b07b. The change replaced Mercurial-backed unit tests with mocks, leaving integration tests responsible for end-to-end validation.

Evaluated by: mr-cal-bot

No scores available.

Issue body

This should speed them up, there are integration tests for ensuring the rest. Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #2714 completely mocked Mercurial unit tests to speed them up while retaining integration coverage; implemented in commit f22b5b07b.
stealth/space-bunny-alpha — closed resolved Merged PR #2714 completely mocked Mercurial tests to speed them up, retaining integration tests for validation; implemented in commit f22b5b07b.
qwen/qwen3.6-35b-a3b — — Merged changes that completely mock Mercurial tests to improve execution speed, relying on integration tests for validation. Approved by reviewer, passed CI, and modified two files.
qwen3.6-35b-a3b-mtp-q6 — — Merged changes that completely mock mercurial tests to improve execution speed, relying on integration tests for coverage. Successfully merged despite a Codecov base commit reporting issue.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#2713 tests: completely mock bzr tests snapcraft merged PR #2713 by sergiusens was merged (commit d36264104, 'tests: completely mock bzr tests'), replacing real bzr invocations in the bzr source-plugin unit tests with mocks for speed, leaving coverage to integration tests.
71%