← Back to issue list

extensions: add gsettings plug to gnome-3-28 extension

View original Github issue

Metadata

Project
snapcraft
Number
#2735
Type
pull request
State
merged
Author
merlijn-sebrechts
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #2735 as commit 86cff633c, adding the gsettings plug to the gnome-3-28 extension so GTK apps pick up the correct theme under Wayland; kenvandine approved.

Resolution: closed resolved

Reason: PR #2735 was approved and merged, landing as commit 86cff633c ("extensions: add gsettings plug to gnome-3-28 extension"). The plug is still applied today in snapcraft/extensions/gnome.py, which appends "gsettings" to plugs for core24 and older.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh tests/unit`? ----- The `gsettings` plug is needed for GTK applications to use the correct theme under Wayland. As a result, every GTK application should add this plug, so it seems better to just do it in the extension itself. https://forum.snapcraft.io/t/gnome-3-28-extension-add-gsettings-to-plugs/13471

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #2735 as commit 86cff633c, adding the gsettings plug to the gnome-3-28 extension so GTK apps pick up the correct theme under Wayland; kenvandine approved.
stealth/space-bunny-alpha — closed resolved Merged PR #2735 via commit 86cff633c, adding the gsettings plug to the gnome-3-28 extension so GTK applications use the correct theme under Wayland.
qwen/qwen3.6-35b-a3b — — Merged the addition of the gsettings plug to the gnome-3-28 extension. This enables GTK applications to use the correct theme under Wayland. Approved by reviewer and passed CI checks.
qwen3.6-35b-a3b-mtp-q6 — — Merged addition of the gsettings plug to the gnome-3-28 extension, enabling correct GTK theming under Wayland. Approved by a maintainer after passing static and unit tests.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/snapcraft#2736 (confidence 35%)

    Follow-up spread test change (commit 1bac91a0c) updating the gnome-3-28 extension spread test to use gtk.

Related issues

Issue Project State Summary Similarity
#3427 extensions: make GNOME 3.38 stable snapcraft merged Merged PR #3427, promoting the GNOME 3.38 extension to stable in commit a99bc7e4e.
70%