← Back to issue list

cli: use click utilities for login prompts

View original Github issue

Metadata

Project
snapcraft
Number
#2742
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Merged refactoring of CLI login prompts to use Click utilities. Approved by one reviewer, the change modified 20 files with a net reduction of 108 lines. Six unresolved review comments were present at merge.

Suggested action: —

No scores available.

Issue body

Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b — — Merged refactoring of CLI login prompts to use Click utilities. Approved by one reviewer, the change modified 20 files with a net reduction of 108 lines. Six unresolved review comments were present at merge.
qwen3.6-35b-a3b-mtp-q6 — — Merged changes to refactor CLI login prompts using Click utilities, standardizing authentication flows and improving command-line consistency.
qwen3.6-35b-a3b-mtp-q6 — — Merged refactoring of CLI login prompts to use Click utilities, authored by maintainer sergiusens. The change standardizes authentication workflows and was integrated into the main branch.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1307 cli: new UI and internal refactor snapcraft merged Merged a complete CLI rewrite using Click, decoupling the library and command-line interface. Approved by a maintainer, passed CI checks, and modified 70 files. Diff coverage reached 98.07%.
73%
#1869 cli: exported login should only be readable by owner snapcraft merged Merged a fix restricting CLI login file permissions to owner-only read access. Replaced click.File with click.Path to manually enforce secure file creation. Approved by two reviewers and passed CI checks.
72%
#2736 cli: prompt for login if required snapcraft merged Merged CLI update that prompts for login when required instead of exiting with an error. Approved and passed CI checks.
72%