← Back to issue list

cli: run review tools before pushing to the store if available

View original Github issue

Metadata

Project
snapcraft
Number
#2783
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Merged #2783 as 04f2a6eb1, adding optional pre-push review checks that report snap v2 lint findings without blocking Store uploads.

Resolution: closed resolved

Reason: PR #2783 was approved and merged as commit 04f2a6eb1. It runs available review tools before Store upload and emits lint errors or warnings without failing the push.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Consider only snap v2 lint warnings and errors. On discovery of any issues, emit warnings, but do not fail as we have no easy way to override any of these issues. Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged #2783 as 04f2a6eb1, adding optional pre-push review checks that report snap v2 lint findings without blocking Store uploads.
stealth/space-bunny-alpha — closed resolved Merged as commit 04f2a6eb1, adding optional pre-push review checks that report snap v2 lint findings as warnings without blocking uploads.
qwen/qwen3.6-35b-a3b — — Merged changes to run review tools before pushing to the store. The update emits warnings for snap v2 lint issues without failing the push. Approved by a reviewer and passed CI checks.
qwen3.6-35b-a3b-mtp-q6 — — Merged. Adds pre-push store checks that run snap review tools, emitting warnings for v2 lint issues without failing the push due to unavailable overrides. Approved after a minor request to add tests.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1009 store: implement push pre-check. snapcraft merged Merged PR #1009 as commit 8d7b53aa3, adding a store pre-check so `snapcraft push` reports unregistered snaps before uploading (LP: #1610776).
74%