← Back to issue list

store: implement push pre-check.

View original Github issue

Metadata

Project
snapcraft
Number
#1009
Type
pull request
State
merged
Author
squidsoup
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #1009 as commit 8d7b53aa3, adding a store pre-check so `snapcraft push` reports unregistered snaps before uploading (LP: #1610776).

Resolution: closed resolved

Reason: PR #1009 was approved and merged into master as commit 8d7b53aa3 ("store: implement push pre-check."), adding a push_precheck request before upload; the three review comments were about adding user-facing progress logging and were addressed before merge.

Evaluated by: mr-cal-bot

No scores available.

Issue body

LP: #1610776 This branch adds a precheck request to the store to `snapcraft push`, which in the case of an unregistered snap will report the error to the user before attempting a full upload.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #1009 as commit 8d7b53aa3, adding a store pre-check so `snapcraft push` reports unregistered snaps before uploading (LP: #1610776).
stealth/space-bunny-alpha — closed resolved Merged PR #1009 as commit 8d7b53aa3, adding a store pre-check to snapcraft push so unregistered snaps fail before a full upload.
stealth/space-bunny-alpha — closed resolved Merged PR #1009 as commit 8d7b53aa3, adding a store pre-check to snapcraft push so unregistered snaps report an error before upload.
qwen/qwen3.6-35b-a3b — — Merged into master. Implements a store pre-check for snapcraft push to validate snap registration before upload, preventing failed transfers. Added a user status message, approved by reviewer, and passed CI checks.
qwen3.6-35b-a3b-mtp-q6 — — Merged after adding a progress message for the store pre-check. The change implements a pre-upload verification step in snapcraft push to catch unregistered snap errors early, improving user feedback and debugging.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#2783 cli: run review tools before pushing to the store if available snapcraft merged Merged #2783 as 04f2a6eb1, adding optional pre-push review checks that report snap v2 lint findings without blocking Store uploads.
74%
#1610776 "snapcraft push" without registering first should fail fast snapcraft (launchpad) closed Fixed by merged PR #1009 (commit 8d7b53aa3), adding a pre-check that rejects unregistered snap names before upload.
73%
#1634 Push metadata to the Store. snapcraft merged Merged Store push-metadata support in canonical/snapcraft#1634 (commit 2f61ad042), with clearer failure guidance and integration coverage.
71%
#2650 store: send snapcraft-started-at in push requests snapcraft merged Merged #2650 as b31299e39, sending snapcraft-started-at in Store push requests so release requests can be ordered by build start time.
71%
#1691597 snapcraft push fails to a registered name snapcraft (launchpad) closed Merged PR #2749 (commit ac2d48293) improved store error handling with StoreErrorList and clearer StorePushError output for forbidden and missing resources.
71%