← Back to issue list

project: pivot `info` from ProjectInfo to Snap

View original Github issue

Metadata

Project
snapcraft
Number
#2818
Type
pull request
State
closed
Author
cjp256
Labels
—
Created
Updated
Closed

Current evaluation

Superseded by #2821: the Snap refactoring was split out, while build-base support was deferred and the broader pivot was not completed.

Resolution: closed superseded

Reason: The author stated on 2019-11-25 that the Snap refactoring was extracted into snapcraft#2821 and that build-base would be handled separately; #2818 was not merged. A later, narrower migration landed in snapcraft#3014 via commit 09be6bb53.

Evaluated by: mr-cal-bot

No scores available.

Issue body

There's really three parts to this PR: 1. The detailing of Snap's from_dict() and to_dict() so as to not rely on the hackish `__dict__` usage. 2. Adding 'build-base' support to Snap. 3. Converging `info` and `_snap_meta` with Snap (and removing ProjectInfo) and moving the raw_snapcraft bits into Project. The motivation for this PR was the mypy uprev. project.info is Optional, and it's usage is extensive across the code base (assuming that's it's not None). Instead of reworking ProjectInfo, I figured it was better to rip it out as it's mostly duplicating functionality of Snap.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed superseded Superseded by #2821: the Snap refactoring was split out, while build-base support was deferred and the broader pivot was not completed.
stealth/space-bunny-alpha — closed superseded Snap refactoring was extracted into #2821; build-base support was deferred and #2818 was closed unmerged.
stealth/space-bunny-alpha — closed superseded Superseded by #2821, which extracted the Snap refactoring; build-base support was deferred for separate work.
qwen/qwen3.6-35b-a3b — — Superseded by PR #2821. The author extracted the Snap refactoring to replace ProjectInfo, closing this PR pending future build-base support implementation.
qwen3.6-35b-a3b-mtp-q6 — — Closed and superseded by PR #2821 after the author extracted the Snap refactoring. Build-base support was deferred for later implementation.

Update history

No update history recorded yet.

Related work

  • Superseded By: snapcraft#2821 (confidence 100%)

    The author explicitly split the Snap refactoring into this follow-up PR.

  • Related To: snapcraft#3014 (confidence 90%)

    Later merged a narrower migration of get_build_base from ProjectInfo to Snap.

Related issues

No related issues found above the similarity threshold.