← Back to issue list

meta: migrate get_build_base to Snap

View original Github issue

Metadata

Project
snapcraft
Number
#3014
Type
pull request
State
merged
Author
sergiusens
Labels
Created
Updated
Closed

Current evaluation

Merged after approval and passing CI. Migrated get_build_base from Projectinfo to Snap, simplifying test fixtures and removing plugin dependencies on self.project.info across 61 files.

Suggested action:

No scores available.

Issue body

Migrate away from its implementation in Projectinfo. The required test changes introduce a simpler fixture by use of Snap to provide the metadata, which removes the every in-Snapcraft plugin's dependency away from self.project.info. Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged after approval and passing CI. Migrated get_build_base from Projectinfo to Snap, simplifying test fixtures and removing plugin dependencies on self.project.info across 61 files.
qwen3.6-35b-a3b-mtp-q6 Merged. Migrated get_build_base from Projectinfo to Snap, simplifying test fixtures and eliminating self.project.info dependencies across Snapcraft plugins.
qwen3.6-35b-a3b-mtp-q6 Merged. The change migrated get_build_base from Projectinfo to Snap, simplifying test fixtures and removing Snapcraft plugins' dependency on self.project.info.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#4580 fix: do not propagate build-base to snap.yaml snapcraft merged Merged a fix preventing build-base from propagating to snap.yaml. The pull request received two approvals, passed CI checks and code coverage, and was successfully integrated.
73%
#5409 docs: migrate 'migrate between bases' snapcraft merged Merged after reviewer approval and CI validation. The pull request migrated documentation for changing Snapcraft bases, restructuring the content into a dedicated how-to guide as agreed in comments.
72%
#2689 schema: build-base support for the snapd type snapcraft merged Merged into master. Implements build-base keyword support for the snapd snap type, enabling its construction. Approved by reviewer, passed CI, and updated four files.
71%
#2309 snap: improve early base detection logic snapcraft merged Merged. Resolved early base detection failure in build providers by updating logic to account for snapcraft's non-project directory execution. Approved by reviewer, passed CI, and merged with minimal changes.
71%