← Back to issue list

meta: migrate get_build_base to Snap

View original Github issue

Metadata

Project
snapcraft
Number
#3014
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Merged in snapcraft#3014 via commit 09be6bb53, moving get_build_base from Projectinfo to Snap and simplifying tests to use Snap metadata instead of self.project.info.

Resolution: closed resolved

Reason: Pull request #3014 was approved and merged as commit 09be6bb53, completing the Projectinfo-to-Snap migration and removing plugin dependencies on self.project.info from affected tests.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Migrate away from its implementation in Projectinfo. The required test changes introduce a simpler fixture by use of Snap to provide the metadata, which removes the every in-Snapcraft plugin's dependency away from self.project.info. Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged in snapcraft#3014 via commit 09be6bb53, moving get_build_base from Projectinfo to Snap and simplifying tests to use Snap metadata instead of self.project.info.
stealth/space-bunny-alpha — closed resolved Merged as snapcraft#3014 (commit 09be6bb53), migrating get_build_base from Projectinfo to Snap and replacing Projectinfo-based test fixtures with simpler Snap metadata.
qwen/qwen3.6-35b-a3b — — Merged after approval and passing CI. Migrated get_build_base from Projectinfo to Snap, simplifying test fixtures and removing plugin dependencies on self.project.info across 61 files.
qwen3.6-35b-a3b-mtp-q6 — — Merged. Migrated get_build_base from Projectinfo to Snap, simplifying test fixtures and eliminating self.project.info dependencies across Snapcraft plugins.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#5409 docs: migrate 'migrate between bases' snapcraft merged Merged in snapcraft#5409 via commit 30aeaf036, migrating and restructuring the documentation for changing snap bases.
76%
#4580 fix: do not propagate build-base to snap.yaml snapcraft merged Merged #4580 (d4e948f33), preventing build-base from being propagated into generated snap.yaml files.
74%
#4755 tests: fix devel base snap test snapcraft merged Merged #4755, fixing the devel-base integration test to verify Snapcraft can create the base snap and that the resulting devel base is usable.
74%
#5467 build: update snap metadata snapcraft merged Merged as commit 6f9e0901a: refreshed the description of the Snapcraft snap (snap/snapcraft.yaml) with wording pulled from the documentation homepage.
73%
#6193 fix: snapcraft try error shows effective base snapcraft merged Merged PR #6193 fixed `snapcraft try` to report the project's effective base via `get_effective_base()`, with core24 and core26 test coverage, in commit bcae1c3ed.
73%
#3096 pluginhandler: export SNAPCRAFT_BUILD_BASE to build environment snapcraft closed The SNAPCRAFT_BUILD_BASE export and snap-meta refresh were proposed in #3096, but the PR was closed without a recorded merge or replacement.
72%
#3637 meta: generate basic snap.yaml (CRAFT-801) snapcraft merged Merged #3637, adding minimal snap.yaml generation from existing project metadata to enable snap packing (0afa3dbfd; merge bc94255b4).
72%
#6187 Fix snapcraft try error to show actual base snapcraft closed Closed unmerged over contribution-guideline concerns; PR #6193 later fixed #6186 by using the effective project base in commit bcae1c3ed.
72%
#2309 snap: improve early base detection logic snapcraft merged Merged PR #2309 (commit 3565ed2e7), fixing early base detection when Snapcraft runs in a build provider outside the project directory (LP #1795501).
72%
#6499 fix: parse build-base for snapcraftctl validation snapcraft merged Fixed a validator bug preventing core22/core24 snaps without a `base` key from using `snapcraftctl`. Merged as #6499, resolving #6336.
71%