remote-build: remove need to specify user
Metadata
Current evaluation
Merged after two approvals and CI. Removes remote build user specification, adds automatic login on init, fixes AcceptPublicUploadError, and deletes unused _waiting from LaunchpadClient across five files.
Suggested action: —
No scores available.
Issue body
A few other tweaks/cleanup while we're here.
remote-build: remove requirement to specify user …
Thanks to @cjwatson for the great idea! :+1:
https://bugs.launchpad.net/snapcraft/+bug/1852482
remote-build: login automatically when initialized …
remote-build: fix AcceptPublicUploadError option …
remote-build: remove _waiting from LaunchpadClient …
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged after two approvals and CI. Removes remote build user specification, adds automatic login on init, fixes AcceptPublicUploadError, and deletes unused _waiting from LaunchpadClient across five files. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged remote-build changes removing the user specification requirement, enabling automatic login on init, fixing the AcceptPublicUploadError option, and removing the unused _waiting attribute from LaunchpadClient, resolving bug #1852482. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged remote-build cleanup removing user specification requirement, enabling automatic login on initialization, fixing AcceptPublicUploadError, and removing unused _waiting from LaunchpadClient. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2690 remote-build: error when --user is required | snapcraft | merged | Merged. Fixes a remote-build regression where the --user flag was not enforced during LaunchpadClient initialization. Refactors config handling, moves init earlier to fail fast, and updates login/push methods to use saved credentials. | |
| #3021 remote-build: remove artifact sanity check | snapcraft | merged | Merged removal of the artifact sanity check in remote-build. The validation incorrectly failed on multi-architecture builds from Launchpad. Removing it enables direct artifact downloads without unnecessary checks. Approved and passed CI. | |
| #2590 remote build: add option to skip public upload question | snapcraft | merged | Merged. Introduces a flag to skip the public upload confirmation prompt during remote builds, supporting non-interactive environments. Approved by two reviewers, passed CI, and includes tty-aware prompts with error handling. | |
| #2837 remote-build: gpg-signing and usability fixes | snapcraft | merged | Merged changes disabling GPG signing for git commits to fix remote-build failures. Improves error messaging and commit formatting. Approved by reviewer, passed CI, and integrated into the codebase. | |
| #3553 cli: make remote-build more user-friendly | snapcraft | merged | Merged improvements to remote-build CLI. Aligns --recover with --status, suppresses unnecessary public data prompts when checking status, and adds tests. Approved and merged. | |
| #2642 remote-build: detect early build errors | snapcraft | merged | Merged. Improved remote build error detection to distinguish between pending builders and actual failures like missing config or timeouts. Approved by reviewer, passed CI, and modified 3 files (+131/-47 lines). Minor import fix applied. |