remote-build: remove artifact sanity check
Metadata
Current evaluation
Merged removal of the artifact sanity check in remote-build. The validation incorrectly failed on multi-architecture builds from Launchpad. Removing it enables direct artifact downloads without unnecessary checks. Approved and passed CI.
Suggested action: —
No scores available.
Issue body
A snapcraft.yaml may have a configuration of `build-on` that allows
Launchpad to pick from a set of architectures that will run on
multiple architectures.
This will fail our sanity check which assumes the arch, which may
in fact end up as `multi`. There isn't really any need to sanity
check the artifacts anyhow, so we'll remove this check and download
whatever Launchpad provides.
LP: #1870730
Signed-off-by: Chris Patterson <chris.patterson@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged removal of the artifact sanity check in remote-build. The validation incorrectly failed on multi-architecture builds from Launchpad. Removing it enables direct artifact downloads without unnecessary checks. Approved and passed CI. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged removal of the remote-build artifact sanity check. The validation failed on multi-arch builds from Launchpad. The unnecessary check was removed to accept any artifacts provided by Launchpad. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Removed the remote-build artifact sanity check that incorrectly failed for multi-architecture builds from Launchpad. The check was unnecessary, so the code now downloads artifacts directly as provided. Resolves LP: #1870730. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #5005 fix(remotebuild): error early for multiple artifacts per build-on | snapcraft | merged | Merged. Adds early validation to prevent Launchpad build failures when multiple artifacts share the same build-on architecture. Replaces cryptic errors with a clear message, resolving issue #4995. Approved and passed CI. | |
| #2825 remote-build: remove need to specify user | snapcraft | merged | Merged after two approvals and CI. Removes remote build user specification, adds automatic login on init, fixes AcceptPublicUploadError, and deletes unused _waiting from LaunchpadClient across five files. | |
| #4495 remote build: odd errors for certain `architectures:` setups | snapcraft | closed | Remote build architecture validation errors and misleading logs were fixed via remote-builder improvements and PR 4994. Conflicting build-for flags now yield a user-friendly error, and Launchpad reporting was corrected. Closed. | |
| #4826 fix(remote-build): fail if no artifacts are created | snapcraft | merged | Merged fix for issue #4783 that ensures remote builds fail when no artifacts are generated. Approved by two reviewers, passed CI, and merged with 214 additions and 4 deletions across two files. |