remote-build: remove artifact sanity check
Metadata
Current evaluation
Merged PR #3021 (commit e4a878561) removed remote-build's artifact arch sanity check, so Launchpad results with arch 'multi' from build-on are downloaded instead of rejected. Fixes LP bug #1870730.
Resolution: closed resolved
Reason: The PR itself was the fix and was merged by maintainer cjp256 (approved, 1 reviewer) as commit e4a878561, deleting the artifact check in the remote-build download path. This resolved LP #1870730 where build-on architectures could build as 'multi' and trip the arch check.
Evaluated by: mr-cal-bot
No scores available.
Issue body
A snapcraft.yaml may have a configuration of `build-on` that allows
Launchpad to pick from a set of architectures that will run on
multiple architectures.
This will fail our sanity check which assumes the arch, which may
in fact end up as `multi`. There isn't really any need to sanity
check the artifacts anyhow, so we'll remove this check and download
whatever Launchpad provides.
LP: #1870730
Signed-off-by: Chris Patterson <chris.patterson@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #3021 (commit e4a878561) removed remote-build's artifact arch sanity check, so Launchpad results with arch 'multi' from build-on are downloaded instead of rejected. Fixes LP bug #1870730. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #3021 (e4a878561) removed remote-build’s artifact sanity check, allowing Launchpad-provided multi-architecture results from build-on instead of rejecting them. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged removal of the artifact sanity check in remote-build. The validation incorrectly failed on multi-architecture builds from Launchpad. Removing it enables direct artifact downloads without unnecessary checks. Approved and passed CI. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged removal of the remote-build artifact sanity check. The validation failed on multi-arch builds from Launchpad. The unnecessary check was removed to accept any artifacts provided by Launchpad. |
Update history
No update history recorded yet.
Related work
-
Related To:
snapcraft (launchpad)#1870730
(confidence 55%)
Body cites Launchpad bug LP: #1870730 as the motivating bug (Launchpad-side tracking, not a snapcraft issue)
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #4826 fix(remote-build): fail if no artifacts are created | snapcraft | merged | Merged in #4826 (commit 552897340): remote-build now fails when Launchpad creates no artifacts, fixing #4783. | |
| #5265 fix(remotebuild): don't fail when cross-compiling | snapcraft | merged | Merged PR #5265 fixed remote cross-compilation by sending build-on architectures to Launchpad; commit f94da8f13 closed #4996. | |
| #2825 remote-build: remove need to specify user | snapcraft | merged | Merged #2825, removing the remote-build user requirement and adding automatic Launchpad login; it also fixed public-upload handling and cleaned up LaunchpadClient. | |
| #2780 remote-build: option renames for arch, user, and accept-public-upload | snapcraft | merged | Merged #2780 renamed remote-build --arch to --build-on and Launchpad-prefixed the user and public-upload options (commits 6ef1767ba, b8e7121e2). | |
| #4481 Clean Launchpad repositories when remote-build errors are raised | snapcraft | closed | Launchpad cleanup for remote-build errors was implemented in commit 663dcdfab; the author confirmed the request was completed. | |
| #2642 remote-build: detect early build errors | snapcraft | merged | Merged PR #2642 by cjp256: remote-build now detects early Launchpad build errors (e.g. missing snapcraft.yaml) instead of misreporting a busy builder; landed as commit 73fd95e86. | |
| #4995 remote build: error if multiple artefacts can be built on the same architecture | snapcraft | closed | Fixed by merged PR #5005 (commit ad3b54bbd): remote builds now fail early when multiple artifacts share a build-on architecture. | |
| #4495 remote build: odd errors for certain `architectures:` setups | snapcraft | closed | Remote-build architecture handling was improved; #4994 (5cd480725) fixed CLI validation and #5005 (ad3b54bbd) rejected unsupported duplicate build-on artifacts. | |
| #4783 remote build: fail if launchpad fails to create artifacts | snapcraft | closed | Remote-build silently succeeded when Launchpad produced no artifacts. Fixed by merged PR #4826 (commit 552897340), which makes snapcraft remote-build fail when no artifacts are created. |