← Back to issue list

appstream extractor: add support for code

View original Github issue

Metadata

Project
snapcraft
Number
#2831
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #2831 as commit 009c92b66, adding an AppStream XSLT template that preserves text inside <code> elements during Markdown transformation.

Resolution: closed resolved

Reason: The merged change added a template matching AppStream <code> elements and processing their children, preventing their text from being swallowed. It landed in commit 009c92b66.

Evaluated by: mr-cal-bot

No scores available.

Issue body

The Markdown used by the Snap Store does not yet support "verbatim" or code-like formatting while Appstream does. The new XSLT snippet is added to ensure these code tags are not swallowed during the transformation. Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #2831 as commit 009c92b66, adding an AppStream XSLT template that preserves text inside <code> elements during Markdown transformation.
stealth/space-bunny-alpha — closed resolved Merged PR #2831 (commit 009c92b66) adds an XSLT snippet to the AppStream extractor so <code>/verbatim text survives Markdown conversion; shipped in Snapcraft 3.10 alongside #2828 (19d7e3496).
stealth/space-bunny-alpha — closed resolved Merged #2831, adding AppStream extractor XSLT to preserve code tags and their text during Markdown transformation.
qwen/qwen3.6-35b-a3b — — Merged a pull request adding XSLT support to preserve code tags during Appstream to Markdown transformation. Approved by a reviewer, passed CI checks, and added 63 lines across two files to prevent code content from being stripped.
qwen3.6-35b-a3b-mtp-q6 — — Merged an appstream extractor update adding an XSLT snippet to preserve code tags during transformation. This prevents code content from being stripped when converting Appstream data to Snap Store Markdown, which lacks native code formatting support.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#2828 Appstream snapcraft merged Merged PR #2828 added AppStream extractor support for <em> emphasis in commit 19d7e3496.
79%
#2430 extractors: better appstream support for descriptions snapcraft merged Merged #2430, improving AppStream description extraction with XSLT normalization, complex-markup support, xml:lang handling, and plain-text output.
77%
#1845309 appstream extractor's xslt needs em and code snapcraft (launchpad) closed AppStream XSLT support for <em> and <code> was added by snapcraft PR #2828 and included in Snapcraft 3.10.
77%
#2832 appstream extractor: take xml comments into account snapcraft merged Merged as commit e4dc754f2, fixing AppStream extraction with XML comments and adding regression coverage for Launchpad bug #1852329.
75%
#1861 extractors: also support appdata.xml appstream files. snapcraft merged Merged PR #1861, adding extractor support for AppStream appdata.xml files, in commit d49c2c202.
73%
#1826 extractors: support appstream metadata in parts snapcraft merged Merged PR #1826 (commit 9cb05f4c5) added an AppStream metadata extractor for parts, initially extracting summary and description. Credits @elopio; closes feature request #1694. Follow-ups: #1853, #1861, #2430.
72%