appstream extractor: take xml comments into account
Metadata
Current evaluation
Merged as commit e4dc754f2, fixing AppStream extraction with XML comments and adding regression coverage for Launchpad bug #1852329.
Resolution: closed resolved
Reason: PR #2832 was approved and merged as commit e4dc754f2. It updates the AppStream XSLT to strip XML comments and adds a TRANSLATORS-comment regression test, resolving the extraction failure.
Evaluated by: mr-cal-bot
No scores available.
Issue body
LP: #1852329
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged as commit e4dc754f2, fixing AppStream extraction with XML comments and adding regression coverage for Launchpad bug #1852329. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in #2832 via commit e4dc754f2, fixing AppStream extraction when XML comments are present and adding regression tests. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in canonical/snapcraft#2832 via commit e4dc754f2, fixing AppStream extraction when XML comments are present and covering the behavior with tests. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged changes to the appstream extractor to properly handle XML comments. Approved by one reviewer with no unresolved comments. Adds 65 lines across two files, resolving Launchpad bug #1852329. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged to update the appstream extractor to properly parse XML comments, resolving launchpad bug #1852329. The change was authored by maintainer sergiusens and integrated into the codebase. |
Update history
No update history recorded yet.
Related work
-
Related To:
snapcraft (launchpad)#1852329
(confidence 99%)
The PR cites this Launchpad bug as the extraction failure addressed by its merged fix.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1852329 appstream parsing fails when comments exist | snapcraft (launchpad) | open | AppStream description parsing broke on XML translator comments; fixed by commit e4dc754f2 (snapcraft#2832), which strips comments in the XSLT and adds a TRANSLATORS-comment regression test. Launchpad bug still open. | |
| #2831 appstream extractor: add support for code | snapcraft | merged | Merged PR #2831 as commit 009c92b66, adding an AppStream XSLT template that preserves text inside <code> elements during Markdown transformation. | |
| #2828 Appstream | snapcraft | merged | Merged PR #2828 added AppStream extractor support for <em> emphasis in commit 19d7e3496. | |
| #2430 extractors: better appstream support for descriptions | snapcraft | merged | Merged #2430, improving AppStream description extraction with XSLT normalization, complex-markup support, xml:lang handling, and plain-text output. | |
| #1861 extractors: also support appdata.xml appstream files. | snapcraft | merged | Merged PR #1861, adding extractor support for AppStream appdata.xml files, in commit d49c2c202. |