← Back to issue list

appstream extractor: take xml comments into account

View original Github issue

Metadata

Project
snapcraft
Number
#2832
Type
pull request
State
merged
Author
sergiusens
Labels
Created
Updated
Closed

Current evaluation

Merged changes to the appstream extractor to properly handle XML comments. Approved by one reviewer with no unresolved comments. Adds 65 lines across two files, resolving Launchpad bug #1852329.

Suggested action:

No scores available.

Issue body

LP: #1852329 Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged changes to the appstream extractor to properly handle XML comments. Approved by one reviewer with no unresolved comments. Adds 65 lines across two files, resolving Launchpad bug #1852329.
qwen3.6-35b-a3b-mtp-q6 Merged to update the appstream extractor to properly parse XML comments, resolving launchpad bug #1852329. The change was authored by maintainer sergiusens and integrated into the codebase.
qwen3.6-35b-a3b-mtp-q6 Merged updates to the appstream extractor to properly parse XML comments, resolving Launchpad bug #1852329. The maintainer's changes were integrated into the main branch.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#2831 appstream extractor: add support for code snapcraft merged Merged a pull request adding XSLT support to preserve code tags during Appstream to Markdown transformation. Approved by a reviewer, passed CI checks, and added 63 lines across two files to prevent code content from being stripped.
77%
#3695 meta: add appstream metadata extractor snapcraft merged Merged after reviewer approval and passing CI. Adds an appstream metadata extractor to parse application metadata from appstream files, modifying 9 files with a net addition of 1192 lines.
74%
#2430 extractors: better appstream support for descriptions snapcraft merged Merged enhancement to AppStream description extraction using XSLT normalization and xml:lang handling. Addressed reviewer feedback to include ordered list support prior to merge.
73%
#2435 Appstream desktop snapcraft merged Merged pull request adding Appstream desktop support. Approved by one reviewer with no unresolved comments. CI passed, modifying 10 files with 95.91% diff coverage.
71%