catkin: remove rospack workaround
Metadata
Current evaluation
Merged PR #2833 in commit 949f90946, removing the Catkin rospack workaround because rosdep can now ignore workspace source packages.
Resolution: closed resolved
Reason: PR #2833 merged as commit 949f90946. It reverted the workaround introduced by #2585 after rosdep gained the ability to ignore source packages.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh tests/unit`?
-----
Reverts a change made in #2585 now that rosdep has grown the ability to ignore source packages on its own.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #2833 in commit 949f90946, removing the Catkin rospack workaround because rosdep can now ignore workspace source packages. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #2833 in commit 949f90946, removing the Catkin rospack workaround and reverting #2585 because rosdep can now ignore workspace source packages. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged removal of a catkin rospack workaround, reverting #2585 as rosdep now natively ignores source packages. Approved by three reviewers and passed CI checks. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Reverts #2585 by removing the catkin rospack workaround, as rosdep now natively ignores source packages. Integrated after resolving mypy cache and import loop test failures. |
Update history
No update history recorded yet.
Related work
-
Related To:
snapcraft#2585
(confidence 99%)
PR #2585 introduced the workspace dependency and rospack workaround that #2833 reverted.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2585 catkin plugin: check workspace for dependencies | snapcraft | merged | Merged PR #2585 (b88e37814) fixed Catkin builds by using rospack to enumerate workspace packages and exclude their internal dependencies from rosdep resolution; resolves LP #1832044. | |
| #1581 catkin plugin: support rosdep pip dependencies | snapcraft | merged | Merged PR #1581 in commit 186ae7f91, adding pip-based rosdep dependency support to the Catkin plugin and fixing LP bug #1683036. | |
| #2847 Catkin plugin: consider only 'local' workspaces | snapcraft | merged | Merged PR #2847 (commit 1d476f622) sources ROS setup with --local, preventing destructive-mode Catkin builds from using host workspaces and skipping dependency installation. | |
| #1832044 Catkin plugin doesn't check the workspace for dependencies | snapcraft (launchpad) | closed | Catkin plugin failed on whole-workspace builds because rosdep (#685) couldn't resolve deps satisfied by in-workspace packages. Workaround merged in snapcraft PR #2585 (commit b88e37814); the workaround was later dropped in #2833 once rosdep was fixed upstream. | |
| #331 Catkin plugin: Handle rosdep empty and multiple dependencies. | snapcraft | merged | PR #331 merged into snapcraft master as commit 1c1119ce3 (merge e3a2b9d03). It refactored the Catkin plugin's rosdep dependency resolution to handle empty output and multiple packages per line, fixing LP bugs #1548406 and #1548404. | |
| #1392 catkin plugin: extract rosdep into new package | snapcraft | merged | Merged in canonical/snapcraft#1392 (99218f59d), extracting rosdep from Catkin into internal.pullers and resolving #1464. | |
| #1548404 Catkin plugin: Can't handle rosdep resolving to multiple packages | snapcraft (launchpad) | closed | Fixed by ubuntu-core/snapcraft PR #331 (commit 1c1119ce3, 'Catkin plugin: Handle rosdep empty and multiple dependencies'), merged as e3a2b9d03; maintainer ~kyrofa linked the PR when closing the Launchpad bug. | |
| #163 Catkin plugin: use rosdep for dependency resolution | snapcraft | merged | Merged in PR #163 (commit 87b2e24f6), replacing manual Catkin package.xml dependency parsing with rosdep; PR #183 backported the change to Snapcraft 1.x. | |
| #1548406 Catkin plugin: Can't handle rosdep resolving to nothing | snapcraft (launchpad) | closed | Fixed by canonical/snapcraft#331, merged as commit 1c1119ce3; Catkin now treats empty rosdep output as no dependencies instead of an error. |