catkin: remove rospack workaround
Metadata
Current evaluation
Merged removal of a catkin rospack workaround, reverting #2585 as rosdep now natively ignores source packages. Approved by three reviewers and passed CI checks.
Suggested action: —
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh tests/unit`?
-----
Reverts a change made in #2585 now that rosdep has grown the ability to ignore source packages on its own.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged removal of a catkin rospack workaround, reverting #2585 as rosdep now natively ignores source packages. Approved by three reviewers and passed CI checks. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Reverts #2585 by removing the catkin rospack workaround, as rosdep now natively ignores source packages. Integrated after resolving mypy cache and import loop test failures. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Removes a catkin rospack workaround by reverting #2585, as rosdep now natively ignores source packages. A reviewer noted a potential mypy cache issue, but the change was accepted and merged. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2585 catkin plugin: check workspace for dependencies | snapcraft | merged | Merged. Resolves LP: #1832044 by updating the Catkin plugin to use rospack for workspace dependency resolution instead of relying solely on the rosdep index. Approved by reviewers and passed all CI checks. | |
| #163 Catkin plugin: use rosdep for dependency resolution | snapcraft | merged | Merged. Replaced manual package.xml parsing with rosdep for Catkin plugin dependency resolution. Reviewers approved the changes, with minor naming suggestions deferred to a future refactor. | |
| #1581 catkin plugin: support rosdep pip dependencies | snapcraft | merged | Merged implementation adding pip-based dependency support to the Catkin plugin's rosdep resolver, resolving Launchpad bug #1683036. Approved by one reviewer, passed CI, and modified 12 files. | |
| #331 Catkin plugin: Handle rosdep empty and multiple dependencies. | snapcraft | merged | Merged refactoring of the Catkin plugin rosdep resolver to handle empty results and multiple dependencies per line. Fixes Launchpad bugs #1548406 and #1548404. Approved by maintainer sergiusens. | |
| #2270 catkin, rosdep: stop using FileNotFoundErrors | snapcraft | merged | Merged. Replaces FileNotFoundError with SnapcraftError-derived exceptions in catkin and rosdep to prevent raw tracebacks from reaching Sentry. Ensures users receive formatted error messages. Approved by one reviewer and passed CI. |