← Back to issue list

catkin plugin: support rosdep pip dependencies

View original Github issue

Metadata

Project
snapcraft
Number
#1581
Type
pull request
State
merged
Author
kyrofa
Labels
Created
Updated
Closed

Current evaluation

Merged implementation adding pip-based dependency support to the Catkin plugin's rosdep resolver, resolving Launchpad bug #1683036. Approved by one reviewer, passed CI, and modified 12 files.

Suggested action:

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh unit`? ----- The Catkin plugin uses rosdep to resolve dependencies, however, the only type of dependencies it currently supports are apt-based. This PR fixes LP: [#1683036](https://bugs.launchpad.net/snapcraft/+bug/1683036) by adding support for pip-based dependencies.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged implementation adding pip-based dependency support to the Catkin plugin's rosdep resolver, resolving Launchpad bug #1683036. Approved by one reviewer, passed CI, and modified 12 files.
qwen3.6-35b-a3b-mtp-q6 Merged. Added pip-based rosdep dependency support to the Catkin plugin, resolving Launchpad bug #1683036. The update extends dependency resolution beyond apt packages to include pip packages.
qwen3.6-35b-a3b-mtp-q6 Merged update adding rosdep pip dependency support to the catkin plugin, resolving Launchpad bug #1683036. Snapcraft now resolves pip-based ros dependencies alongside existing apt-based ones.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1683036 Catkin plugin doesn't support rosdep dependencies that resolve to pip snapcraft (launchpad) closed Support for rosdep dependencies resolving to pip in the Catkin plugin was closed without implementation. The request appears abandoned, leaving pip resolution unsupported.
84%
#1444 catkin pip support snapcraft closed Catkin pip support was implemented via PRs #1479 and #1540. These changes updated rosdep parsing and extracted Python helpers, enabling the catkin plugin to install pip dependencies alongside debs.
84%
#1479 rosdep: add support for multiple dependency types snapcraft merged Merged to add rosdep support for parsing multiple dependency types. The catkin plugin was updated to use the new API, currently limited to debs, laying groundwork for future pip dependency integration. Approved and passed CI.
82%
#331 Catkin plugin: Handle rosdep empty and multiple dependencies. snapcraft merged Merged refactoring of the Catkin plugin rosdep resolver to handle empty results and multiple dependencies per line. Fixes Launchpad bugs #1548406 and #1548404. Approved by maintainer sergiusens.
81%
#163 Catkin plugin: use rosdep for dependency resolution snapcraft merged Merged. Replaced manual package.xml parsing with rosdep for Catkin plugin dependency resolution. Reviewers approved the changes, with minor naming suggestions deferred to a future refactor.
80%
#183 Backport to 1.x: Catkin plugin: use rosdep for dependency resolution. snapcraft merged Merged backport of #163 to the 1.x branch. The catkin plugin now uses rosdep for dependency resolution, updating three files with 547 additions and 147 deletions.
78%
#1367 catkin plugin: add support for ROS Lunar snapcraft merged Merged the catkin plugin update to support ROS Lunar alongside Indigo, Jade, and Kinetic. CI initially failed due to a Launchpad bug, resolved by adding lsb-release to build-packages. Approved and merged after passing integration tests.
78%
#1314 catkin plugin: add support for rosinstall files snapcraft merged Merged. Introduces a rosinstall-files property to the Catkin plugin, allowing Snapcraft to manage ROS workspace dependencies. Approved by a reviewer and merged after resolving CI test delays. Resolves Launchpad bug 1533735.
77%
#1392 catkin plugin: extract rosdep into new package snapcraft merged Merged. Extracts rosdep from the catkin plugin into snapcraft.plugins.internal.pullers to enable future Ament and ROS 2 support. Updates plugin loading to ignore internal packages, resolving issue #1464.
76%
#2585 catkin plugin: check workspace for dependencies snapcraft merged Merged. Resolves LP: #1832044 by updating the Catkin plugin to use rospack for workspace dependency resolution instead of relying solely on the rosdep index. Approved by reviewers and passed all CI checks.
76%