← Back to issue list

catkin plugin: support rosdep pip dependencies

View original Github issue

Metadata

Project
snapcraft
Number
#1581
Type
pull request
State
merged
Author
kyrofa
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #1581 in commit 186ae7f91, adding pip-based rosdep dependency support to the Catkin plugin and fixing LP bug #1683036.

Resolution: closed resolved

Reason: PR canonical/snapcraft#1581 was merged as commit 186ae7f91. It added pip-based rosdep dependency handling to the Catkin plugin and fixes LP bug #1683036.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh unit`? ----- The Catkin plugin uses rosdep to resolve dependencies, however, the only type of dependencies it currently supports are apt-based. This PR fixes LP: [#1683036](https://bugs.launchpad.net/snapcraft/+bug/1683036) by adding support for pip-based dependencies.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #1581 in commit 186ae7f91, adding pip-based rosdep dependency support to the Catkin plugin and fixing LP bug #1683036.
stealth/space-bunny-alpha — closed resolved Merged as commit 186ae7f91, adding pip-based rosdep dependency support to the Catkin plugin and fixing LP bug #1683036.
stealth/space-bunny-alpha — closed resolved Merged PR #1581 added pip-based rosdep dependency support to Snapcraft's Catkin plugin, resolving LP bug #1683036 in commit 186ae7f91.
stealth/space-bunny-alpha — closed resolved Merged PR #1581 (commit 186ae7f91), adding pip-based rosdep dependency support to Snapcraft's Catkin plugin and fixing LP bug #1683036.
stealth/space-bunny-alpha — closed resolved Merged PR #1581 (commit 186ae7f91) adding pip-based rosdep dependency support to the Catkin plugin, fixing LP bug #1683036.
stealth/space-bunny-alpha — closed resolved Merged as canonical/snapcraft#1581 (commit 186ae7f91), adding pip-based rosdep dependency support to the Catkin plugin and fixing LP bug #1683036.
stealth/space-bunny-alpha — closed resolved Merged PR #1581 (commit 186ae7f91), adding pip-based rosdep dependency support to the Catkin plugin and fixing LP #1683036.
qwen/qwen3.6-35b-a3b — — Merged implementation adding pip-based dependency support to the Catkin plugin's rosdep resolver, resolving Launchpad bug #1683036. Approved by one reviewer, passed CI, and modified 12 files.
qwen3.6-35b-a3b-mtp-q6 — — Merged. Added pip-based rosdep dependency support to the Catkin plugin, resolving Launchpad bug #1683036. The update extends dependency resolution beyond apt packages to include pip packages.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1444 catkin pip support snapcraft closed Catkin gained pip-based rosdep dependency support via merged PR #1581 (commit 186ae7f91), following groundwork in #1479 and #1540.
91%
#1683036 Catkin plugin doesn't support rosdep dependencies that resolve to pip snapcraft (launchpad) closed Catkin support for rosdep dependencies resolving to pip was merged in snapcraft PR #1581, commit 186ae7f91.
84%
#163 Catkin plugin: use rosdep for dependency resolution snapcraft merged Merged in PR #163 (commit 87b2e24f6), replacing manual Catkin package.xml dependency parsing with rosdep; PR #183 backported the change to Snapcraft 1.x.
83%
#1479 rosdep: add support for multiple dependency types snapcraft merged Merged PR #1479 (commit 4b2f86d76) added multi-type rosdep parsing and adapted Catkin; pip dependency installation remained follow-up work.
81%
#331 Catkin plugin: Handle rosdep empty and multiple dependencies. snapcraft merged PR #331 merged into snapcraft master as commit 1c1119ce3 (merge e3a2b9d03). It refactored the Catkin plugin's rosdep dependency resolution to handle empty output and multiple packages per line, fixing LP bugs #1548406 and #1548404.
80%
#1392 catkin plugin: extract rosdep into new package snapcraft merged Merged in canonical/snapcraft#1392 (99218f59d), extracting rosdep from Catkin into internal.pullers and resolving #1464.
79%
#183 Backport to 1.x: Catkin plugin: use rosdep for dependency resolution. snapcraft merged Merged into 1.x via PR #183, backporting PR #163 so Catkin uses rosdep instead of manually parsing package.xml dependencies.
79%
#1548406 Catkin plugin: Can't handle rosdep resolving to nothing snapcraft (launchpad) closed Fixed by canonical/snapcraft#331, merged as commit 1c1119ce3; Catkin now treats empty rosdep output as no dependencies instead of an error.
77%
#1548404 Catkin plugin: Can't handle rosdep resolving to multiple packages snapcraft (launchpad) closed Fixed by ubuntu-core/snapcraft PR #331 (commit 1c1119ce3, 'Catkin plugin: Handle rosdep empty and multiple dependencies'), merged as e3a2b9d03; maintainer ~kyrofa linked the PR when closing the Launchpad bug.
77%
#1314 catkin plugin: add support for rosinstall files snapcraft merged Merged PR #1314 as commit 97a416d0a, adding ordered multi-file rosinstall support to the Catkin plugin and resolving Launchpad #1533735.
76%