← Back to issue list

remote-build: gpg-signing and usability fixes

View original Github issue

Metadata

Project
snapcraft
Number
#2837
Type
pull request
State
merged
Author
cjp256
Labels
Created
Updated
Closed

Current evaluation

Merged changes disabling GPG signing for git commits to fix remote-build failures. Improves error messaging and commit formatting. Approved by reviewer, passed CI, and integrated into the codebase.

Suggested action:

No scores available.

Issue body

remote-build: use easier to read git commit message format sources: introduce GitCommandError for improved user-facing errors sources: improve command quoting in SnapcraftPullError sources: disable gpg signing for git commit @flexiondotorg reported his git config enabled GPG signing which broke remote-build's use of git. This series disables gpg-signing as well as improves user-facing messaging in a few areas so the user can more easily determine what went wrong.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged changes disabling GPG signing for git commits to fix remote-build failures. Improves error messaging and commit formatting. Approved by reviewer, passed CI, and integrated into the codebase.
qwen3.6-35b-a3b-mtp-q6 Merged fix that disables GPG signing for git commits in remote-build, resolving breakage from user git configurations. Also improves error messaging and commit formatting.
qwen3.6-35b-a3b-mtp-q6 Merged. Disables GPG signing for git commits in remote-build, fixing breakage when users had GPG signing enabled. Also improves error messaging and commit formatting. Author adjusted commit messages per feedback before merge.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#4432 fix(remote-build): improve logging and catch exceptions snapcraft merged Merged pull request improving remote build logging and exception handling. Approved by reviewers, passed CI checks, and resolves issue #4399.
77%
#2642 remote-build: detect early build errors snapcraft merged Merged. Improved remote build error detection to distinguish between pending builders and actual failures like missing config or timeouts. Approved by reviewer, passed CI, and modified 3 files (+131/-47 lines). Minor import fix applied.
77%
#3553 cli: make remote-build more user-friendly snapcraft merged Merged improvements to remote-build CLI. Aligns --recover with --status, suppresses unnecessary public data prompts when checking status, and adds tests. Approved and merged.
74%
#310 fix(remote-build): enable git repo check craft-application merged Successfully merged the fix enabling the git repository check for remote builds. Approved by two reviewers, the update modifies two files with 18 additions and 1 deletion, resolving the build configuration issue.
74%
#2564 remote_build: handle git push in detached head state snapcraft merged Merged fix for remote_build that resolves a detached HEAD exception by returning HEAD instead of failing branch name retrieval. Approved by reviewer and passed CI checks.
74%
#1546 feat: remote build command charmcraft merged Merged the remote build command feature. Approved by two reviewers and passing CI, the PR rebases prior work and adds remote build functionality. Follow-up issues were created to resolve related build-id recovery and dependency bugs.
72%
#2798 cli: improve the remote-build upload messaging snapcraft merged Merged changes improving CLI remote-build upload messaging. The update replaces public with publicly available to clarify artifact visibility. Approved by reviewer, passed CI, and integrated with minimal code changes.
72%
#3056 remote-build: package up local sources with source-type 'git' snapcraft merged Merged after approval. Implements remote-build packaging for local sources with source-type 'git'. Approved by one reviewer with zero unresolved comments. Changes modify 2 files (+10/-3 lines).
72%
#2825 remote-build: remove need to specify user snapcraft merged Merged after two approvals and CI. Removes remote build user specification, adds automatic login on init, fixes AcceptPublicUploadError, and deletes unused _waiting from LaunchpadClient across five files.
72%
#2634 remote build: fully preserve local sources and support packaging all sources snapcraft merged Merged into remote-build. Preserves local sources and enables packaging all sources. Modified 13 files (+673/-528). Iterative updates addressed review feedback, fixed tests, resolved Git import issues, and updated dependencies. Approved by one reviewer.
72%