fix(remote-build): improve logging and catch exceptions
Metadata
Current evaluation
Merged #4432, adding RemoteBuildError handling and improving remote-build logging for #4399; commits fb9a01d0b and 663dcdfab.
Resolution: closed resolved
Reason: PR #4432 was merged after approval by two reviewers. Its changes catch remote-build errors and improve logging, resolving the relevant #4399 work.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `make lint`?
- [x] Have you successfully run `pytest tests/unit`?
-----
Catch `RemoteBuildErrors` and improve the UX for remote building.
The launchpad authorization message (see below) still doesn't look great because it adds its own newlines. It is directly printed by `launchpadlib` and I'm not sure there is a straightforward way to make it look better.
```python
"Please open this authorization page:\n"
" (%s)\n"
"in your browser. Use your browser to authorize\n"
"this program to access Launchpad on your behalf."
```
Fixes #4399
(CRAFT-2096)
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged #4432, adding RemoteBuildError handling and improving remote-build logging for #4399; commits fb9a01d0b and 663dcdfab. | |
| stealth/space-bunny-alpha | — | closed resolved | PR #4432 (mr-cal) merged, adding RemoteBuildError catching and improved logging for remote-build; fixes #4399 (CRAFT-2096). Launchpad authorization line breaks left as-is. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #4432 added RemoteBuildError handling and improved remote-build logging for #4399; Launchpad authorization text still had awkward line breaks. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged pull request improving remote build logging and exception handling. Approved by reviewers, passed CI checks, and resolves issue #4399. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged by mr-cal, the change fixes #4399 by catching RemoteBuildErrors and enhancing logging and UX for remote builds. Launchpadlib authorization message formatting remains unaltered due to library constraints. |
Update history
No update history recorded yet.
Related work
-
Related To:
snapcraft#4399
(confidence 100%)
The PR body explicitly states “Fixes #4399.”
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #4480 fix(remote): return error when remote build failed | snapcraft | merged | Merged PR #4480 as commit 13aedd1d2, making remote builds return an error when a build fails and fixing #4142. | |
| #2837 remote-build: gpg-signing and usability fixes | snapcraft | merged | Merged #2837: remote-build now disables Git commit signing and improves source errors, command quoting, and commit-message readability. | |
| #4395 feat(remote-build): new command logic | snapcraft | merged | Merged as commit 2e0647594; adds RemoteBuild class and new remote-build command orchestration, per-build project cache in the local cache dir with post-build cleanup, plus typing/lint updates (CRAFT-1979). Fixes #4324. | |
| #2798 cli: improve the remote-build upload messaging | snapcraft | merged | Merged #2798 as 850b5dee8, clarifying that remote-build uploads are publicly available rather than necessarily public. | |
| #4396 fix(remote-build): warn instead of error when using unsupported bases | snapcraft | merged | Merged #4396 via commit 5d19d28bd to make remote-build warn instead of fail for unsupported bases, fixing #4357. | |
| #4399 Improve UX for new remote-build | snapcraft | closed | Remote-build logging was improved in fb9a01d0b; the remaining multiline status display was closed as out of scope. | |
| #5052 fix: catch remote build errors | snapcraft | merged | Merged in #5052 (commit 741e36eb9), updating craft-application to 4.2.4 so remote-build errors are caught as CraftErrors and include documentation links; fixes #4908. | |
| #3076 remote-build: fix case where build log url is None | snapcraft | merged | Merged in snapcraft#3076 (commit 2c1dfe63c), fixing remote-build handling when the build log URL is absent and adding unit coverage. | |
| #4384 refactor(remote-build): reorganize functions | snapcraft | merged | Merged #4384 via commit 23e2601c9, reorganizing remote-build functions in preparation for #4322; follow-up #4385 added build-ID generation. | |
| #2594 remote build: don't send log files back to remote | snapcraft | merged | Merged PR #2594 in commit 5800e0aff, updating remote-build filters to exclude locally retrieved build logs from project files uploaded to the remote builder. |