fix(remote-build): improve logging and catch exceptions
Metadata
Current evaluation
Merged pull request improving remote build logging and exception handling. Approved by reviewers, passed CI checks, and resolves issue #4399.
Suggested action: —
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `make lint`?
- [x] Have you successfully run `pytest tests/unit`?
-----
Catch `RemoteBuildErrors` and improve the UX for remote building.
The launchpad authorization message (see below) still doesn't look great because it adds its own newlines. It is directly printed by `launchpadlib` and I'm not sure there is a straightforward way to make it look better.
```python
"Please open this authorization page:\n"
" (%s)\n"
"in your browser. Use your browser to authorize\n"
"this program to access Launchpad on your behalf."
```
Fixes #4399
(CRAFT-2096)
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged pull request improving remote build logging and exception handling. Approved by reviewers, passed CI checks, and resolves issue #4399. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged by mr-cal, the change fixes #4399 by catching RemoteBuildErrors and enhancing logging and UX for remote builds. Launchpadlib authorization message formatting remains unaltered due to library constraints. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged to improve remote build logging and catch RemoteBuildErrors, enhancing user experience. Resolves #4399. Launchpad authorization formatting remains unchanged. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #4480 fix(remote): return error when remote build failed | snapcraft | merged | Successfully merged fix for remote build failures that returns proper errors, resolving issue #4142. Approved by three reviewers with maintained code coverage across 13 files. | |
| #2642 remote-build: detect early build errors | snapcraft | merged | Merged. Improved remote build error detection to distinguish between pending builders and actual failures like missing config or timeouts. Approved by reviewer, passed CI, and modified 3 files (+131/-47 lines). Minor import fix applied. | |
| #2594 remote build: don't send log files back to remote | snapcraft | merged | Merged a fix updating build log filters to prevent local logs from being sent to the remote builder. Approved by reviewer, passed CI, and modified two files with four additions and four deletions. | |
| #4826 fix(remote-build): fail if no artifacts are created | snapcraft | merged | Merged fix for issue #4783 that ensures remote builds fail when no artifacts are generated. Approved by two reviewers, passed CI, and merged with 214 additions and 4 deletions across two files. | |
| #351 fix(remotebuild): use full project name in log files | craft-application | merged | Merged a fix ensuring remote build log files use the full project name, resolving issue #4781. Approved by three reviewers, passed CI, and updated two files. | |
| #2837 remote-build: gpg-signing and usability fixes | snapcraft | merged | Merged changes disabling GPG signing for git commits to fix remote-build failures. Improves error messaging and commit formatting. Approved by reviewer, passed CI, and integrated into the codebase. | |
| #1546 feat: remote build command | charmcraft | merged | Merged the remote build command feature. Approved by two reviewers and passing CI, the PR rebases prior work and adds remote build functionality. Follow-up issues were created to resolve related build-id recovery and dependency bugs. | |
| #310 fix(remote-build): enable git repo check | craft-application | merged | Successfully merged the fix enabling the git repository check for remote builds. Approved by two reviewers, the update modifies two files with 18 additions and 1 deletion, resolving the build configuration issue. | |
| #4882 docs: add explanation for remote build | snapcraft | merged | Merged documentation update detailing current and legacy remote builder behaviors. Approved by reviewers and passed CI. Resolves issue #4842 by establishing comprehensive guidance prior to future behavioral changes. | |
| #2681 fix: correctly get project name for remote builds | charmcraft | merged | Merged after three approvals. Corrects project name retrieval for remote builds, resolving #2598. Integrated despite non-blocking type-checking warnings and two unresolved review comments. |