← Back to issue list

project: remove unused errors

View original Github issue

Metadata

Project
snapcraft
Number
#2855
Type
pull request
State
merged
Author
cjp256
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #2855, removing unused SanityCheckError and CommandChainWithLegacyAdapterError in commit 8d3a2cec6.

Resolution: closed resolved

Reason: PR #2855 was approved and merged, deleting 17 lines for two unused exception definitions. The change is recorded in commit 8d3a2cec6.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Remove SanityCheckError and CommandChainWithLegacyAdapterError. Signed-off-by: Chris Patterson <chris.patterson@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #2855, removing unused SanityCheckError and CommandChainWithLegacyAdapterError in commit 8d3a2cec6.
stealth/space-bunny-alpha — closed resolved Merged PR #2855, removing the unused SanityCheckError and CommandChainWithLegacyAdapterError classes (17 deleted lines in one file).
qwen/qwen3.6-35b-a3b — — Merged after approval and passing CI checks. Removes the unused SanityCheckError and CommandChainWithLegacyAdapterError classes, deleting 17 lines of code across one file.
qwen3.6-35b-a3b-mtp-q6 — — Merged cleanup removing unused SanityCheckError and CommandChainWithLegacyAdapterError classes. The maintainer submitted the change directly, with no additional review or comments required.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#2375 sanity checks: verify that command-chain is not used with legacy adapter snapcraft merged Merged in PR #2375 as commit 57c7fb8d0, adding sanity checks that reject command-chain with the incompatible legacy app adapter, fixing LP #1798918.
71%