sanity checks: verify that command-chain is not used with legacy adapter
Metadata
Current evaluation
Merged in PR #2375 as commit 57c7fb8d0, adding sanity checks that reject command-chain with the incompatible legacy app adapter, fixing LP #1798918.
Resolution: closed resolved
Reason: PR #2375 was merged as commit 57c7fb8d0. Its post-extension build-time checks reject command-chain when the legacy app adapter is used, resolving LP #1798918.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh tests/unit`?
-----
This PR fixes [LP: #1798918](https://bugs.launchpad.net/snapcraft/+bug/1798918) by introducing sanity checks that run in the build environment after all extensions have been applied, and ensuring that `command-chain` is not used in combination with the `legacy` app adapter (they are incompatible).
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged in PR #2375 as commit 57c7fb8d0, adding sanity checks that reject command-chain with the incompatible legacy app adapter, fixing LP #1798918. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #2375 (commit 57c7fb8d0), adding build-time sanity checks that reject command-chain with the incompatible legacy app adapter and resolving LP: #1798918. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in PR #2375 (commit 57c7fb8d0), adding post-extension sanity checks that reject command-chain with the legacy app adapter, fixing LP: #1798918. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in snapcore/snapcraft#2375 as commit 57c7fb8d0, adding build-environment sanity checks that reject command-chain with the incompatible legacy adapter and fixing LP #1798918. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged to master, adding sanity checks that block the incompatible combination of command-chain and the legacy app adapter, resolving LP: #1798918. Approved by one reviewer, passed CI, and reached 97.22% diff coverage. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Implemented build-time sanity checks to prevent using command-chain with the legacy app adapter, resolving Launchpad bug #1798918. |
Update history
No update history recorded yet.
Related work
-
Related To:
snapcraft (launchpad)#1798918
(confidence 100%)
Launchpad bug #1798918 was fixed by this merged PR.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1798918 command-chain is incompatible with legacy adapter, but snapcraft doesn't say so | snapcraft (launchpad) | closed | Added a sanity check rejecting command-chain use with the legacy app adapter in snapcore/snapcraft#2375 (commit 57c7fb8d0). | |
| #2836 meta: fix command-chain handling when Application adapter == "none" | snapcraft | closed | PR #2836 was closed unmerged on 2020-01-07 by author cjp256 in favor of a simpler back-portable PR #2853, which was merged (commit 9599497fb) and fixed adapter: none adding snapcraft-runner to command-chain. | |
| #2855 project: remove unused errors | snapcraft | merged | Merged PR #2855, removing unused SanityCheckError and CommandChainWithLegacyAdapterError in commit 8d3a2cec6. |