meta: assume command-chain fix for prepending snapcraft-runner
Metadata
Current evaluation
Merged #2864 in commit 94e9ef908, correcting assumes detection when snapcraft-runner is prepended via command-chain and adding test coverage.
Resolution: closed resolved
Reason: PR #2864 was approved and merged as commit 94e9ef908. The change checks prepend_command_chain when adding command-chain assumes and updates unit tests.
Evaluated by: mr-cal-bot
No scores available.
Issue body
`prepend_command_chain` was not checked when determining the need
for assuming command-chain.
- Add & update a test to ensure coverage of `assumes`.
- Check for use of `prepend_command_chain`.
Signed-off-by: Chris Patterson <chris.patterson@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged #2864 in commit 94e9ef908, correcting assumes detection when snapcraft-runner is prepended via command-chain and adding test coverage. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #2864 (94e9ef908), fixing command-chain assumptions for prepended snapcraft-runner and expanding assumes tests. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged a fix adding a missing check for prepend_command_chain when determining if command-chain should be assumed in metadata. Includes updated assumes coverage tests. Approved by one reviewer and passed CI checks. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged fix ensuring snap metadata correctly assumes command-chain when prepend_command_chain is used. Added and updated tests to verify assumes coverage. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2796 meta: ensure Snap's `assumes` is initialized as a set | snapcraft | merged | Merged PR #2796 (commit 2f3a9cc14) initialized Snap metadata's assumes as a set and added tests, fixing command-chain failures when the assumption was absent. | |
| #2879 [3.9-backport] meta: ensure Snap's `assumes` is initialized as a set | snapcraft | merged | Merged backport #2879 (commit 2f3a9cc14) fixed SNAPCRAFT-16C by initializing Snap assumes as a set, preventing command-chain .add() exceptions. Backported from #2796. | |
| #2891 meta: always generate snapcraft-runner to workaround classic (#2889) | snapcraft | merged | Merged in PR #2891 as commit 343ac2862, adding an empty snapcraft-runner command-chain workaround for classic apps with incorrect PATH handling and unit tests. | |
| #4931 Failed to upload snap created with `assumes: - command-chain` | snapcraft | open | Declaring `assumes: [command-chain]` in snapcraft.yaml duplicates the entry, producing a snap.yaml rejected by snap-review. Still unfixed at HEAD; fix PR #6445 was closed unmerged. | |
| #1799295 Snapcraft should add an "assumes" if full adapter is used | snapcraft (launchpad) | closed | Fixed by snapcraft PR #2379 ("meta: add assumes if using 'full' app adapter"), merged as commit 2b5a254ef; Snapcraft now adds assumes: [command-chain] when the full adapter is used. Maintainer ~kyrofa closed LP #1799295 citing that PR. | |
| #3741 parts: replace snapcraft command-chain with environment | snapcraft | merged | Merged #3741 as ec190695c, replacing core22 snapcraft_runner command-chain handling with command-chain and global LD_LIBRARY_PATH/PATH defaults while deprecating adapter. |