meta: assume command-chain fix for prepending snapcraft-runner
Metadata
Current evaluation
Merged a fix adding a missing check for prepend_command_chain when determining if command-chain should be assumed in metadata. Includes updated assumes coverage tests. Approved by one reviewer and passed CI checks.
Suggested action: —
No scores available.
Issue body
`prepend_command_chain` was not checked when determining the need
for assuming command-chain.
- Add & update a test to ensure coverage of `assumes`.
- Check for use of `prepend_command_chain`.
Signed-off-by: Chris Patterson <chris.patterson@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged a fix adding a missing check for prepend_command_chain when determining if command-chain should be assumed in metadata. Includes updated assumes coverage tests. Approved by one reviewer and passed CI checks. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged fix ensuring snap metadata correctly assumes command-chain when prepend_command_chain is used. Added and updated tests to verify assumes coverage. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a fix to check prepend_command_chain when determining if the command-chain assumption is required. Added unit tests to verify assumes coverage for snap metadata generation. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2379 meta: add assumes if using "full" app adapter | snapcraft | merged | Merged into master. Automatically adds assumes: [command-chain] to snap metadata when using the full app adapter, resolving LP: #1799295. Approved, passed CI, and achieved 100% diff coverage. | |
| #2796 meta: ensure Snap's `assumes` is initialized as a set | snapcraft | merged | Merged fix for SNAPCRAFT-16C that converts the assumes configuration from a list to a set during initialization. This resolves a runtime exception when using command-chain by ensuring the add method functions correctly. Includes updated unit tests. | |
| #2861 meta: remove Application's `prepend_command_chain` | snapcraft | merged | Merged after approval and CI. Removed the ambiguous prepend_command_chain member and renamed _generate_command_chain to _generate_snapcraft_runner to simplify command-chain handling. Assumes fix separated into PR #2864. | |
| #2912 meta: do not prime commands with adapter == "none" | snapcraft | merged | Merged fix ensuring Snapcraft passes commands through unmodified when adapter is set to none, aligning with wrapper and snapcraft-runner behavior. Includes unit and spread test updates. Approved and passed CI. | |
| #2891 meta: always generate snapcraft-runner to workaround classic (#2889) | snapcraft | merged | Merged as #2889. Introduces an empty snapcraft-runner to the command-chain to fix incorrect PATH resolution for classic snap apps. Includes unit tests and configurable fixtures. Approved by reviewers and passed CI. |