Snapcraft should add an "assumes" if full adapter is used
Metadata
Current evaluation
Fixed by snapcraft PR #2379 ("meta: add assumes if using 'full' app adapter"), merged as commit 2b5a254ef; Snapcraft now adds assumes: [command-chain] when the full adapter is used. Maintainer ~kyrofa closed LP #1799295 citing that PR.
Resolution: closed resolved
Reason: Maintainer ~kyrofa commented that the issue was resolved by snapcore/snapcraft PR #2379, which merged as commit 2b5a254ef ("meta: add assumes if using 'full' app adapter"). That change is still present in current code, where snapcraft/meta/snap_yaml.py _create_snap_app() adds "command-chain" (and snapd2.74) to the assumes set.
Evaluated by: mr-cal-bot
Issue body
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Fixed by snapcraft PR #2379 ("meta: add assumes if using 'full' app adapter"), merged as commit 2b5a254ef; Snapcraft now adds assumes: [command-chain] when the full adapter is used. Maintainer ~kyrofa closed LP #1799295 citing that PR. | |
| stealth/space-bunny-alpha | — | closed resolved | Fixed by merged PR #2379 (commit 2b5a254ef), which auto-adds assumes: [command-chain] when the full adapter is used; logic still present in snapcraft/meta/snap_yaml.py. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #2379 (commit 2b5a254ef) adds assumes: [command-chain] automatically when the full app adapter is used. | |
| qwen/qwen3.6-35b-a3b | — | — | Requesting automatic assumes field insertion for the full adapter was closed without resolution. With zero comments and over eight years of inactivity, the feature request was abandoned. | |
| qwen/qwen3.6-35b-a3b | — | — | Closed without implementation. No code changes were merged or discussion initiated, indicating the feature request was abandoned or superseded. | |
| qwen/qwen3.6-35b-a3b | — | — | Closed as abandoned due to inactivity. The feature request to automatically inject assumes directives for the full adapter was never implemented. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Closed without implementation. The request to automatically inject an assumes field for the full adapter was abandoned due to prolonged inactivity and zero discussion. |
Update history
| Date | Change |
|---|---|
| created |
Related work
-
Likely Fixed By:
snapcraft#2379
(confidence 97%)
Merged PR cited by the maintainer as the resolution; merge commit 2b5a254ef adds assumes: [command-chain] for the full adapter.
-
Related To:
snapcraft#2343
(confidence 90%)
Earlier merged PR (d99c1fe43) that introduced the 'full' app adapter, which this issue's assumes handling was needed for.
-
Related To:
snapcraft#2382
(confidence 78%)
Follow-up fix (tests: missing full adapter in extension test) adjusting expectations after the assumes change.
-
Related To:
snapcraft#2864
(confidence 62%)
Later fix 'meta: assume command-chain fix for prepending snapcraft-runner' touching the same assumes/command-chain generation path.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2379 meta: add assumes if using "full" app adapter | snapcraft | merged | Merged as commit 2b5a254ef, adding assumes: [command-chain] when the full app adapter is used, resolving LP #1799295. | |
| #2019931 snapcraft is ignoring the "assumes" section | snapcraft (launchpad) | closed | Snapcraft 7.3.1 dropped project-provided assumes from meta/snap.yaml (hit core22 builds and Docker). Fixed by snapcore/snapcraft PR #4152 (commit 36dca729e); reporter confirmed working in 7.3.2. | |
| #2879 [3.9-backport] meta: ensure Snap's `assumes` is initialized as a set | snapcraft | merged | Merged backport #2879 (commit 2f3a9cc14) fixed SNAPCRAFT-16C by initializing Snap assumes as a set, preventing command-chain .add() exceptions. Backported from #2796. | |
| #2796 meta: ensure Snap's `assumes` is initialized as a set | snapcraft | merged | Merged PR #2796 (commit 2f3a9cc14) initialized Snap metadata's assumes as a set and added tests, fixing command-chain failures when the assumption was absent. | |
| #2864 meta: assume command-chain fix for prepending snapcraft-runner | snapcraft | merged | Merged #2864 in commit 94e9ef908, correcting assumes detection when snapcraft-runner is prepended via command-chain and adding test coverage. | |
| #1548225 Snapcraft/snappy should detect incompatible version mismatches | snapcraft (launchpad) | closed | Closed as superseded after snapd added early validity checks and the assumes mechanism; Snapcraft added assumes support in #525 (e98e34c86). | |
| #2343 schema, meta: add "full" app adapter | snapcraft | merged | Merged PR #2343 (commit d99c1fe43), adding the full app adapter via snapd command-chain instead of wrappers; legacy remained the default for compatibility. | |
| #525 Support the assumes keyword | snapcraft | merged | Merged support for the assumes keyword, passing feature tags from snapcraft.yaml into snap.yaml; resolving commit e98e34c86 fixed LP #1586429. |